Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 620433002: specialize setConcat for scale+translate (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

specialize setConcat for scale+translate, helps drawText perf BUG=skia: Committed: https://skia.googlesource.com/skia/+/e8db3ef2a2161084fa8eb1fd1d54c35bfff52d6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -41 lines) Patch
M include/core/SkMatrix.h View 1 chunk +23 lines, -0 lines 0 comments Download
M src/core/SkMatrix.cpp View 9 chunks +21 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
ptal
6 years, 2 months ago (2014-09-30 14:02:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620433002/1
6 years, 2 months ago (2014-09-30 14:03:25 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-30 14:03:27 UTC) #5
jvanverth1
lgtm
6 years, 2 months ago (2014-09-30 14:09:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as e8db3ef2a2161084fa8eb1fd1d54c35bfff52d6c
6 years, 2 months ago (2014-09-30 14:24:50 UTC) #7
robertphillips
6 years, 2 months ago (2014-10-02 11:42:38 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/620973003/ by robertphillips@google.com.

The reason for reverting is: Experimental to see if this revert "fixes"
nanobench on the main console..

Powered by Google App Engine
This is Rietveld 408576698