Carnitas: Remove chrome/browser/views, update references.

Remove the stubbed out headers in chrome/browser/views.
Update references to use headers in chrome/browser/ui/views.
Update copyright dates in affected files.

/chrome/browser/ui/views/constrained_html_delegate_win.cc
Add space before 'private' label (presubmit warning)
/chrome/browser/ui/views/toolbar_view.cc
Add space before 'cleanup' label (presubmit warning)

BUG=69082
TEST=Compiling...

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70965

[msw, 2011-01-10 00:38:28]

Please review my first Carnitas task, ditching browser/views.
I couldn't find a bug for this; should I log one?

http://codereview.chromium.org/6204002/diff/19001/base/sys_info_win.cc
File base/sys_info_win.cc (right):

http://codereview.chromium.org/6204002/diff/19001/base/sys_info_win.cc#newcode67
base/sys_info_win.cc:67: // See chrome/browser/ui/views/bug_report_view.cc,
BugReportView::SetOSVersion.
Not sure what this comment is referencing.
There is no chrome/browser/ui/views/bug_report_view.cc

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/dragged_tab_controller.cc (right):

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/dragged_tab_controller.cc:30: #include
"chrome/browser/ui/views/tabs/tab_strip.h"
What's up with this diff?

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar_view.cc (right):

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar_view.cc:351: cleanup:
I got this pre-submit error:
/cygdrive/d/src/chrome-git/src/chrome/browser/ui/views/toolbar_view.cc:351: 
Labels should always be indented at least one space.  If this is a
member-initializer list in a constructor or the base class list in a class
definition, the colon should be on the following line.  [whitespace/labels] [4]

[Ben Goodger (Google), 2011-01-10 17:09:29]

Thanks for this! - Rubber stamp LGTM mostly. (Checked a few representative
files).

http://codereview.chromium.org/6204002/diff/19001/base/sys_info_win.cc
File base/sys_info_win.cc (right):

http://codereview.chromium.org/6204002/diff/19001/base/sys_info_win.cc#newcode67
base/sys_info_win.cc:67: // See chrome/browser/ui/views/bug_report_view.cc,
BugReportView::SetOSVersion.
On 2011/01/10 00:38:29, msw wrote:
> Not sure what this comment is referencing.
> There is no chrome/browser/ui/views/bug_report_view.cc

Probably just wishful thinking about functionality this class might provide.
Sounds like there's an implementation directly in BugReportView right now.
Without reading into it, I'd say it sounds like in the future that functionality
could move into this class and BugReportView could just use it.

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar_view.cc (right):

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar_view.cc:351: cleanup:
Simple, just indent 1 space before cleanup:. e.g.

  int foo = 5;
  if (foo == 4)
    goto eek;
  ++foo;
 eek:
  LOG(WARNING) << foo;

[msw, 2011-01-10 17:54:00]

Done, one last try job for sanity, then I'll land this.

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar_view.cc (right):

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar_view.cc:351: cleanup:
On 2011/01/10 17:09:30, Ben Goodger wrote:
> Simple, just indent 1 space before cleanup:. e.g.
> 
>   int foo = 5;
>   if (foo == 4)
>     goto eek;
>   ++foo;
>  eek:
>   LOG(WARNING) << foo;
> 

Done. The codebase has both, 1 and 0 spaces...

[Ben Goodger (Google), 2011-01-10 17:55:02]

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar_view.cc (right):

http://codereview.chromium.org/6204002/diff/19001/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar_view.cc:351: cleanup:
According to the error then, the latter is wrong :-)