src/IceOperand.cpp - Issue 620373004: Subzero: Add a few performance measurement tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceOperand.cpp

Issue 620373004: Subzero: Add a few performance measurement tools. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Minor fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceOperand.cpp

diff --git a/src/IceOperand.cpp b/src/IceOperand.cpp

index 26ef83089a064191b569fa88b0b34effbe4c94bc..4eaa297e3594d5cb85e9dd1424c47fda06b00f02 100644

--- a/src/IceOperand.cpp

+++ b/src/IceOperand.cpp

@@ -275,7 +275,7 @@ const Inst *VariableTracking::getSingleDefinition() const {

void VariablesMetadata::init() {

static TimerIdT IDvmetadata = GlobalContext::getTimerID("vmetadata");

- TimerMarker T(IDvmetadata, Func->getContext());

+ TimerMarker T(IDvmetadata, Func);

Metadata.clear();

Metadata.resize(Func->getNumVariables());

@@ -434,7 +434,7 @@ void LiveRange::dump(Ostream &Str) const {

Str << "(weight=" << Weight << ") ";

bool First = true;

for (const RangeElementType &I : Range) {

- if (First)

+ if (!First)

Str << ", ";

First = false;

Str << "[" << I.first << ":" << I.second << ")";

« src/IceGlobalContext.cpp ('K') | « src/IceGlobalContext.cpp ('k') | src/IceRegAlloc.cpp » ('j') | src/IceTimerTree.h » ('J')