Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issue 620373003: Revert of Making WebRTC Java api avaliable in Chromium. (Closed)

Created:
6 years, 2 months ago by mikhal1
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Making WebRTC Java api avaliable in Chromium. (patchset #6 id:120001 of https://codereview.chromium.org/551793003/) Reason for revert: Speculative revert, breaking official win builders. Original issue's description: > Making WebRTC Java api avaliable in Chromium. > > BUG=383418 > TEST=Build target libjingle_peerconnection_javalib > > Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0 > Cr-Commit-Position: refs/heads/master@{#297801} > > Committed: https://crrev.com/0d8b69077ac03b7ea176d9df6f3730fe7a63a499 > Cr-Commit-Position: refs/heads/master@{#298073} TBR=hellner@chromium.org,kjellander@chromium.org,serya@chromium.org NOTREECHECKS=true NOTRY=true BUG=383418 Committed: https://crrev.com/ae1244a85d8f761a2c4c3812cfb6b8112ea08afb Cr-Commit-Position: refs/heads/master@{#298119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mikhal1
Created Revert of Making WebRTC Java api avaliable in Chromium.
6 years, 2 months ago (2014-10-03 23:28:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620373003/1
6 years, 2 months ago (2014-10-03 23:30:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5b66d9e455dda7d1bc3433d02a2a37cabe083746
6 years, 2 months ago (2014-10-03 23:34:25 UTC) #3
hellner1
lgtm
6 years, 2 months ago (2014-10-03 23:34:43 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 23:34:53 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae1244a85d8f761a2c4c3812cfb6b8112ea08afb
Cr-Commit-Position: refs/heads/master@{#298119}

Powered by Google App Engine
This is Rietveld 408576698