Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 620333002: Use invalidation sets for :invalid/:valid/:required/:optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormElement.cpp
diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp
index 880b9adeb8a9de71c2e87bc0b52c31361df87af0..5e5df71263c78d5f45f263e62ed16e95f39ea3fd 100644
--- a/Source/core/html/HTMLFormElement.cpp
+++ b/Source/core/html/HTMLFormElement.cpp
@@ -728,7 +728,8 @@ void HTMLFormElement::setNeedsValidityCheck()
// For now unconditionally order style recalculation, which triggers
dglazkov 2014/10/24 17:13:25 Is this comment still valid?
rune 2014/10/24 20:12:26 Yes. With this CL we still recalculate style witho
// validity recalculation. In the near future, implement validity cache and
// recalculate style only if it changed.
- setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::createWithExtraData(StyleChangeReason::PseudoClass, StyleChangeExtraData::Invalid));
+ pseudoStateChanged(CSSSelector::PseudoValid);
+ pseudoStateChanged(CSSSelector::PseudoInvalid);
}
bool HTMLFormElement::checkValidity()
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698