pkg/analysis_server/test/services/completion/imported_computer_test.dart - Issue 620293002: refactor library prefix suggestion generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/imported_computer_test.dart

Issue 620293002: refactor library prefix suggestion generation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/completion/completion_test_util.dart ('k') | pkg/analysis_server/test/services/completion/local_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/imported_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/imported_computer_test.dart b/pkg/analysis_server/test/services/completion/imported_computer_test.dart

index 56d574875b2ce80fd78eb864af427ff5c40fa111..b6ff16dcc4f7b5a4c3194524cece0a357d8d7f33 100644

--- a/pkg/analysis_server/test/services/completion/imported_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/imported_computer_test.dart

@@ -53,10 +53,7 @@ class ImportedTypeComputerTest extends AbstractCompletionTest {

assertNotSuggested('D');

assertSuggestClass('EE');

assertNotSuggested('F');

- // Don't suggest library prefix as it is suggested by local computer

- // TODO (danrubel) modify so that imported_computer handles

- // all aspects of import statement

- assertNotSuggested('g');

+ assertSuggestLibraryPrefix('g');

assertNotSuggested('G');

assertSuggestClass('H', CompletionRelevance.LOW);

// Should not suggest compilation unit elements