Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 620263002: Update showKeyboard method to be more aggressive. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update showKeyboard method to be more aggressive. Keyboard does not show up in certain cases (like landscape phones on JB devices) by simply using InputMethodManager.SHOW_IMPLICIT. BUG=411854 Committed: https://crrev.com/f277bafe5e3ac6b4e01d2f6d2ddbef1a3f3aeed4 Cr-Commit-Position: refs/heads/master@{#297944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M ui/android/java/src/org/chromium/ui/UiUtils.java View 3 chunks +29 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
6 years, 2 months ago (2014-10-02 21:38:13 UTC) #2
Ted C
lgtm
6 years, 2 months ago (2014-10-02 21:45:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620263002/1
6 years, 2 months ago (2014-10-02 21:53:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as db34482fd7ad1816ca44b2d9856bd1f3e68ae864
6 years, 2 months ago (2014-10-02 23:18:02 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 23:21:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f277bafe5e3ac6b4e01d2f6d2ddbef1a3f3aeed4
Cr-Commit-Position: refs/heads/master@{#297944}

Powered by Google App Engine
This is Rietveld 408576698