Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 620223002: Add Yahoo domains to HSTS preload list. (Closed)

Created:
6 years, 2 months ago by palmer
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Do include subdomains. #

Patch Set 3 : Rebase, and auto-generate the .h with the new compressed representation. JSON is the sole source of… #

Patch Set 4 : Set include_subdomains back to false. #

Patch Set 5 : include_subdomains = true for {login,edit}.yahoo.com. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1437 lines, -1311 lines) Patch
M net/http/transport_security_state_static.h View 1 2 3 4 1 chunk +1351 lines, -1310 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 2 3 4 1 chunk +86 lines, -1 line 0 comments Download

Messages

Total messages: 11 (1 generated)
palmer
PTAL.
6 years, 2 months ago (2014-10-02 19:02:32 UTC) #2
agl
Why is include_subdomains false? It should always be true unless there's a good reason otherwise. ...
6 years, 2 months ago (2014-10-02 19:10:49 UTC) #3
palmer
> Why is include_subdomains false? It should always be true unless there's a good > ...
6 years, 2 months ago (2014-10-06 19:34:17 UTC) #4
agl
lgtm
6 years, 2 months ago (2014-10-07 20:52:04 UTC) #5
Scott Beardsley
On 2014/10/06 19:34:17, Chromium Palmer wrote: > > Why is include_subdomains false? It should always ...
6 years, 2 months ago (2014-10-07 21:46:45 UTC) #6
palmer
> Actually, there are legacy subdomains of http://search.yahoo.com which do not support > HTTPS currently ...
6 years, 2 months ago (2014-10-07 23:05:49 UTC) #7
Scott Beardsley
On 2014/10/07 23:05:49, Chromium Palmer wrote: > OK, I set it back to false. Thanks! ...
6 years, 2 months ago (2014-10-08 08:12:15 UTC) #8
Scott Beardsley
On 2014/10/08 08:12:15, Scott Beardsley wrote: > On 2014/10/07 23:05:49, Chromium Palmer wrote: > > ...
6 years, 2 months ago (2014-10-08 21:14:24 UTC) #9
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/1bf7c6397be697e964bc02b44d5e806af2e77d9c Cr-Commit-Position: refs/heads/master@{#299354}
6 years, 2 months ago (2014-10-13 20:21:00 UTC) #10
palmer
6 years, 2 months ago (2014-10-13 20:21:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
1bf7c6397be697e964bc02b44d5e806af2e77d9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698