Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 620193002: Rename dependent configs to public_configs in speex. (Closed)

Created:
6 years, 2 months ago by brettw
Modified:
6 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename dependent configs to public_configs in speex. This is the new GN name for this variable. TBR=scottmg Committed: https://crrev.com/f1e2f6e17f6f233503b85ee1a0754b8af6d02d9c Cr-Commit-Position: refs/heads/master@{#297857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/speex/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
6 years, 2 months ago (2014-10-02 17:10:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620193002/1
6 years, 2 months ago (2014-10-02 17:11:48 UTC) #4
scottmg
lgtm
6 years, 2 months ago (2014-10-02 17:14:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8fef89b5be23f16e04f9d0b15c867cb802b1b294
6 years, 2 months ago (2014-10-02 17:51:30 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 17:52:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1e2f6e17f6f233503b85ee1a0754b8af6d02d9c
Cr-Commit-Position: refs/heads/master@{#297857}

Powered by Google App Engine
This is Rietveld 408576698