Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/devtools/device/android_device_manager.h

Issue 620183002: DevTools: Merged AndroidWebSocket and AndroidWebSocketImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/device/android_web_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/android_device_manager.h
diff --git a/chrome/browser/devtools/device/android_device_manager.h b/chrome/browser/devtools/device/android_device_manager.h
index fbc00cd722ee9c9aaae93c1a6b812aa9ac89bf8f..835f1606ed83d394ac714a330c7bc8e3b294d083 100644
--- a/chrome/browser/devtools/device/android_device_manager.h
+++ b/chrome/browser/devtools/device/android_device_manager.h
@@ -53,6 +53,7 @@ class AndroidDeviceManager
};
typedef base::Callback<void(const DeviceInfo&)> DeviceInfoCallback;
+ class Device;
class AndroidWebSocket {
public:
@@ -66,9 +67,28 @@ class AndroidDeviceManager
virtual ~Delegate() {}
};
- virtual ~AndroidWebSocket() {}
+ ~AndroidWebSocket();
- virtual void SendFrame(const std::string& message) = 0;
+ void SendFrame(const std::string& message);
+
+ private:
+ friend class Device;
+ class WebSocketImpl;
+
+ AndroidWebSocket(
+ scoped_refptr<Device> device,
+ const std::string& socket_name,
+ const std::string& url,
+ AndroidWebSocket::Delegate* delegate);
+ void Connected(int result, scoped_ptr<net::StreamSocket> socket);
+ void OnFrameRead(const std::string& message);
+ void OnSocketClosed();
+
+ scoped_refptr<Device> device_;
+ WebSocketImpl* socket_impl_;
+ Delegate* delegate_;
+ base::WeakPtrFactory<AndroidWebSocket> weak_factory_;
+ DISALLOW_COPY_AND_ASSIGN(AndroidWebSocket);
};
class DeviceProvider;
@@ -76,10 +96,6 @@ class AndroidDeviceManager
class Device : public base::RefCountedThreadSafe<Device>,
public base::NonThreadSafe {
public:
- typedef AndroidDeviceManager::DeviceInfoCallback DeviceInfoCallback;
- typedef AndroidDeviceManager::CommandCallback CommandCallback;
- typedef AndroidDeviceManager::SocketCallback SocketCallback;
-
void QueryDeviceInfo(const DeviceInfoCallback& callback);
void OpenSocket(const std::string& socket_name,
@@ -92,7 +108,6 @@ class AndroidDeviceManager
void HttpUpgrade(const std::string& socket_name,
const std::string& url,
const SocketCallback& callback);
-
AndroidWebSocket* CreateWebSocket(
const std::string& socket_name,
const std::string& url,
@@ -101,12 +116,14 @@ class AndroidDeviceManager
std::string serial() { return serial_; }
private:
+ friend class base::RefCountedThreadSafe<Device>;
friend class AndroidDeviceManager;
+ friend class AndroidWebSocket;
+
Device(scoped_refptr<base::MessageLoopProxy> device_message_loop,
scoped_refptr<DeviceProvider> provider,
const std::string& serial);
- friend class base::RefCountedThreadSafe<Device>;
virtual ~Device();
scoped_refptr<base::MessageLoopProxy> device_message_loop_;
« no previous file with comments | « no previous file | chrome/browser/devtools/device/android_web_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698