Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: content/browser/media/webrtc_browsertest.cc

Issue 620133002: Re-enabling fixed WebRTC browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/files/file_util.h" 6 #include "base/files/file_util.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/threading/platform_thread.h" 8 #include "base/threading/platform_thread.h"
9 #include "content/browser/web_contents/web_contents_impl.h" 9 #include "content/browser/web_contents/web_contents_impl.h"
10 #include "content/public/common/content_switches.h" 10 #include "content/public/common/content_switches.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 "callEmptyThenAddOneStreamAndRenegotiate({video: true, audio: true});"; 190 "callEmptyThenAddOneStreamAndRenegotiate({video: true, audio: true});";
191 MakeTypicalPeerConnectionCall(kJavascript); 191 MakeTypicalPeerConnectionCall(kJavascript);
192 } 192 }
193 193
194 // Below 2 test will make a complete PeerConnection-based call between pc1 and 194 // Below 2 test will make a complete PeerConnection-based call between pc1 and
195 // pc2, and then use the remote stream to setup a call between pc3 and pc4, and 195 // pc2, and then use the remote stream to setup a call between pc3 and pc4, and
196 // then verify that video is received on pc3 and pc4. 196 // then verify that video is received on pc3 and pc4.
197 // The stream sent from pc3 to pc4 is the stream received on pc1. 197 // The stream sent from pc3 to pc4 is the stream received on pc1.
198 // The stream sent from pc4 to pc3 is cloned from stream the stream received 198 // The stream sent from pc4 to pc3 is cloned from stream the stream received
199 // on pc2. 199 // on pc2.
200 // Flaky on win xp. http://crbug.com/304775 200 #if defined(THREAD_SANITIZER)
201 #if defined(OS_WIN) 201 // Flaky on TSAN v2. http://crbug.com/373637
202 #define MAYBE_CanForwardRemoteStream DISABLED_CanForwardRemoteStream 202 #define MAYBE_CanForwardRemoteStream DISABLED_CanForwardRemoteStream
203 #define MAYBE_CanForwardRemoteStream720p DISABLED_CanForwardRemoteStream720p 203 #define MAYBE_CanForwardRemoteStream720p DISABLED_CanForwardRemoteStream720p
204 #else 204 #else
205 #define MAYBE_CanForwardRemoteStream CanForwardRemoteStream 205 #define MAYBE_CanForwardRemoteStream CanForwardRemoteStream
206 // Flaky on TSAN v2. http://crbug.com/373637
207 #if defined(THREAD_SANITIZER)
208 #define MAYBE_CanForwardRemoteStream720p DISABLED_CanForwardRemoteStream720p
209 #else
210 #define MAYBE_CanForwardRemoteStream720p CanForwardRemoteStream720p 206 #define MAYBE_CanForwardRemoteStream720p CanForwardRemoteStream720p
211 #endif 207 #endif
212 #endif
213 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, MAYBE_CanForwardRemoteStream) { 208 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, MAYBE_CanForwardRemoteStream) {
214 #if defined (OS_ANDROID) 209 #if defined (OS_ANDROID)
215 // This test fails on Nexus 5 devices. 210 // This test fails on Nexus 5 devices.
216 // TODO(henrika): see http://crbug.com/362437 and http://crbug.com/359389 211 // TODO(henrika): see http://crbug.com/362437 and http://crbug.com/359389
217 // for details. 212 // for details.
218 base::CommandLine::ForCurrentProcess()->AppendSwitch( 213 base::CommandLine::ForCurrentProcess()->AppendSwitch(
219 switches::kDisableWebRtcHWDecoding); 214 switches::kDisableWebRtcHWDecoding);
220 #endif 215 #endif
221 MakeTypicalPeerConnectionCall( 216 MakeTypicalPeerConnectionCall(
222 "callAndForwardRemoteStream({video: true, audio: false});"); 217 "callAndForwardRemoteStream({video: true, audio: false});");
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 434
440 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CallAndVerifyVideoMutingWorks) { 435 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CallAndVerifyVideoMutingWorks) {
441 MakeTypicalPeerConnectionCall("callAndEnsureVideoTrackMutingWorks();"); 436 MakeTypicalPeerConnectionCall("callAndEnsureVideoTrackMutingWorks();");
442 } 437 }
443 438
444 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CreateOfferWithOfferOptions) { 439 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CreateOfferWithOfferOptions) {
445 MakeTypicalPeerConnectionCall("testCreateOfferOptions();"); 440 MakeTypicalPeerConnectionCall("testCreateOfferOptions();");
446 } 441 }
447 442
448 } // namespace content 443 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698