Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 620123002: DevTools: Support JS frames save/load for tracing timeline. (Closed)

Created:
6 years, 2 months ago by alph
Modified:
6 years, 2 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Support JS frames save/load for tracing timeline. BUG=363976 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183164

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -8 lines) Patch
M LayoutTests/inspector/tracing/timeline-enum-stability-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 6 chunks +49 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
alph
6 years, 2 months ago (2014-10-02 13:10:57 UTC) #2
yurys
lgtm https://codereview.chromium.org/620123002/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js File Source/devtools/front_end/timeline/TracingTimelineModel.js (right): https://codereview.chromium.org/620123002/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode72 Source/devtools/front_end/timeline/TracingTimelineModel.js:72: CpuProfile: "CpuProfile", Can you move this event at ...
6 years, 2 months ago (2014-10-02 16:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620123002/20001
6 years, 2 months ago (2014-10-02 21:17:41 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 22:22:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183164

Powered by Google App Engine
This is Rietveld 408576698