Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 620093006: Use +- 2B for unbounded draw ops. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use +- 2B for unbounded draw ops. This lets us skip a check inside SkTileGrid::insert(). BUG=skia: Committed: https://skia.googlesource.com/skia/+/0a528c187ab2221e9720d17d1bc76123b5fa8788

Patch Set 1 #

Patch Set 2 : constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/core/SkRecordDraw.cpp View 1 6 chunks +12 lines, -6 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years, 2 months ago (2014-10-02 16:46:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620093006/20001
6 years, 2 months ago (2014-10-02 16:47:47 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-02 16:47:47 UTC) #5
robertphillips
lgtm - but I feel dirty
6 years, 2 months ago (2014-10-02 20:00:58 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:03:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 0a528c187ab2221e9720d17d1bc76123b5fa8788

Powered by Google App Engine
This is Rietveld 408576698