Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 620093004: Added test spec for ChromiumOS builders in chromium.memory. (Closed)

Created:
6 years, 2 months ago by Sergiy Byelozyorov
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Alexander Potapenko, earthdok, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added test spec for ChromiumOS builders in chromium.memory. BUG=399735 R=machenbach@chromium.org Committed: https://crrev.com/7140c07e6c801d9277bf9385f090a7eba96940d6 Cr-Commit-Position: refs/heads/master@{#297838}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Sorted list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M testing/buildbot/chromium.memory.json View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergiy Byelozyorov
6 years, 2 months ago (2014-10-02 13:58:12 UTC) #1
Sergiy Byelozyorov
Note that "unit" includes "views_unittests" for win32 only, but since this test is also executed ...
6 years, 2 months ago (2014-10-02 13:58:59 UTC) #2
Michael Achenbach
LGTM. Also adding the usual suspects. https://codereview.chromium.org/620093004/diff/1/testing/buildbot/chromium.memory.json File testing/buildbot/chromium.memory.json (right): https://codereview.chromium.org/620093004/diff/1/testing/buildbot/chromium.memory.json#newcode223 testing/buildbot/chromium.memory.json:223: "ipc_tests", nit: alpha-sort
6 years, 2 months ago (2014-10-02 14:09:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620093004/20001
6 years, 2 months ago (2014-10-02 14:17:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d5a158ec7ab4b6bcbda524c14d6e6b9cb48187c7
6 years, 2 months ago (2014-10-02 15:32:05 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 15:32:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7140c07e6c801d9277bf9385f090a7eba96940d6
Cr-Commit-Position: refs/heads/master@{#297838}

Powered by Google App Engine
This is Rietveld 408576698