Record whether Geolocation is accessed from a secure origin.

Source/modules/geolocation/Geolocation.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Torch Mobile, Inc.
  * Copyright 2010, The Android Open Source Project
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 11 matching lines @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/geolocation/Geolocation.h"
 
 #include "core/dom/Document.h"
+#include "core/frame/UseCounter.h"
 #include "modules/geolocation/Coordinates.h"
 #include "modules/geolocation/GeolocationController.h"
 #include "modules/geolocation/GeolocationError.h"
 #include "modules/geolocation/GeolocationPosition.h"
 #include "wtf/CurrentTime.h"
 
 namespace blink {
 
 static const char permissionDeniedErrorMessage[] = "User denied Geolocation";
 static const char failedToStartServiceErrorMessage[] = "Failed to start Geolocation service";
@@ skipping 88 matching lines @@
 {
     LocalFrame* frame = this->frame();
     if (!frame)
         return 0;
 
     m_lastPosition = createGeoposition(GeolocationController::from(frame)->lastPosition());
 
     return m_lastPosition.get();
 }
 
+void Geolocation::RecordOriginTypeAccess()
+{
+    ASSERT(frame());
+
+    Document* document = frame()->document();
+    if (!document)

[Peter Beverloo, 2014/10/02 14:58:24]

When would there not be a document if we have the frame? We seem to assume in
other places (e.g. Geolocation::watchPosition) that the executionContext() is
alive. Can we ASSERT instead?

[mlamouri (slow - plz ping), 2014/10/02 15:44:54]

Done.

+        return;
+
+    // It is required but canAccessFeatureRequiringSecureOrigin() but isn't
+    // actually used. This could be used later if a warning is shown in the
+    // developer console.
+    String insecureOriginMsg;
+    UseCounter::Feature counter = document->securityOrigin()->canAccessFeatureRequiringSecureOrigin(insecureOriginMsg)
+        ? UseCounter::GeolocationSecureOrigin : UseCounter::GeolocationInsecureOrigin;
+    UseCounter::count(document, counter);

[Peter Beverloo, 2014/10/02 14:58:24]

I would much prefer this code to use SecurityOrigin::isSecure() based on the
document's URL. Right now, it would consider localhost URLs as being secure
either, which I don't think we should include in the UMA.

[Mike West, 2014/10/02 15:04:11]

We're using canAccessFeature* for security checks (like ServiceWorker) now. If
that's the definition we're running with, it's what we should measure.

+}
+
 void Geolocation::getCurrentPosition(PositionCallback* successCallback, PositionErrorCallback* errorCallback, const Dictionary& options)
 {
     if (!frame())
         return;
 
+    RecordOriginTypeAccess();
+
     GeoNotifier* notifier = GeoNotifier::create(this, successCallback, errorCallback, PositionOptions::create(options));
     startRequest(notifier);
 
     m_oneShots.add(notifier);
 }
 
 int Geolocation::watchPosition(PositionCallback* successCallback, PositionErrorCallback* errorCallback, const Dictionary& options)
 {
     if (!frame())
         return 0;
 
+    RecordOriginTypeAccess();
+
     GeoNotifier* notifier = GeoNotifier::create(this, successCallback, errorCallback, PositionOptions::create(options));
     startRequest(notifier);
 
     int watchID;
     // Keep asking for the next id until we're given one that we don't already have.
     do {
         watchID = executionContext()->circularSequentialID();
     } while (!m_watchers.add(watchID, notifier));
     return watchID;
 }
@@ skipping 350 matching lines @@
                 notifier->startTimer();
             else
                 notifier->setFatalError(PositionError::create(PositionError::POSITION_UNAVAILABLE, failedToStartServiceErrorMessage));
         } else {
             notifier->setFatalError(PositionError::create(PositionError::PERMISSION_DENIED, permissionDeniedErrorMessage));
         }
     }
 }
 
 } // namespace blink