Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 620003004: Files.app: Move UI related sources into the ui directory. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Move UI related sources into the ui directory. BUG=267281 TEST=run Files.app Committed: https://crrev.com/18eda8c91a4de4f19b4caacfd20acb8870ed2a87 Cr-Commit-Position: refs/heads/master@{#297804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4847 lines) Patch
D ui/file_manager/file_manager/foreground/js/combobutton.js View 1 chunk +0 lines, -154 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/commandbutton.js View 1 chunk +0 lines, -136 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/default_action_dialog.js View 1 chunk +0 lines, -161 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/directory_tree.js View 1 chunk +0 lines, -1125 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/drag_selector.js View 1 chunk +0 lines, -242 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/drive_banners.js View 1 chunk +0 lines, -670 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/error_dialog.js View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/file_grid.js View 1 chunk +0 lines, -314 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/file_table.js View 1 chunk +0 lines, -758 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 chunk +15 lines, -15 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/scrollbar.js View 1 chunk +0 lines, -306 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/share_dialog.js View 1 chunk +0 lines, -309 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/suggest_apps_dialog.js View 1 chunk +0 lines, -555 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/tree.css.js View 1 chunk +0 lines, -59 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/combobutton.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/commandbutton.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/default_action_dialog.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/drag_selector.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/drive_banners.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/error_dialog.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/file_table.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/scrollbar.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/share_dialog.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/file_manager/foreground/js/ui/tree.css.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +15 lines, -15 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
6 years, 2 months ago (2014-10-02 09:32:14 UTC) #2
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-10-02 09:32:26 UTC) #3
yoshiki
lgtm
6 years, 2 months ago (2014-10-02 10:44:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620003004/1
6 years, 2 months ago (2014-10-02 10:58:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 50e53345bf148685ea0aaba83873489f292f544b
6 years, 2 months ago (2014-10-02 11:14:45 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 11:15:42 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/18eda8c91a4de4f19b4caacfd20acb8870ed2a87
Cr-Commit-Position: refs/heads/master@{#297804}

Powered by Google App Engine
This is Rietveld 408576698