complete overhaul of webtry work partition between jail and host

complete overhaul of webtry work partition between jail and host

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b77955e1b1b94f5a472b4f5fc620d5dc83425a1f

[humper, 2014-10-01 15:29:23]

humper@google.com changed reviewers:
+ jcgregorio@google.com

[humper, 2014-10-01 15:29:35]

PTAL; this is what's running on skfiddle right now.

[tfarina, 2014-10-01 15:33:37]

https://codereview.chromium.org/619943002/diff/1/experimental/webtry/setup/co...
File experimental/webtry/setup/continue_install.sh (right):

https://codereview.chromium.org/619943002/diff/1/experimental/webtry/setup/co...
experimental/webtry/setup/continue_install.sh:24: mkdir ${HOME}/golib
do you mind writing this as:

mkdir ${HOME}/golib
export GOROOT=${HOME}/go
export GOPATH=${HOME}/golib
export PATH=$PATH:$GOROOT/bin

I think it is slightly clear.

[humper, 2014-10-01 16:09:53]

https://codereview.chromium.org/619943002/diff/1/experimental/webtry/setup/co...
File experimental/webtry/setup/continue_install.sh (right):

https://codereview.chromium.org/619943002/diff/1/experimental/webtry/setup/co...
experimental/webtry/setup/continue_install.sh:24: mkdir ${HOME}/golib
On 2014/10/01 15:33:37, tfarina wrote:
> do you mind writing this as:
> 
> mkdir ${HOME}/golib
> export GOROOT=${HOME}/go
> export GOPATH=${HOME}/golib
> export PATH=$PATH:$GOROOT/bin
> 
> I think it is slightly clear.

Done.

[jcgregorio, 2014-10-01 16:39:51]

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/scri...
File experimental/webtry/scripts/fiddle_wrapper (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/scri...
experimental/webtry/scripts/fiddle_wrapper:18: ./fiddle_run $1
fiddle_gyp, fiddle_ninja, and fiddle_run all need short comments in them to look
at this file to see how they are used.

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
File experimental/webtry/setup/continue_install.sh (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
experimental/webtry/setup/continue_install.sh:20: wget
https://go.googlecode.com/files/go1.2.1.linux-amd64.tar.gz
Can we upgrade to 1.3.3?

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
File experimental/webtry/setup/continue_install_jail.sh (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
experimental/webtry/setup/continue_install_jail.sh:6: umount /dev/shm
Add a comment about what's going on here with the umount/mount.

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
File experimental/webtry/setup/webtry_setup.sh (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
experimental/webtry/setup/webtry_setup.sh:36: # skia and depot_tools.  we split
up the installation process into
We

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/webt...
File experimental/webtry/webtry.go (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/webt...
experimental/webtry/webtry.go:819: //cmd := hash + " --out " + hash + ".png"
commented out code?

[humper, 2014-10-01 17:02:44]

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/scri...
File experimental/webtry/scripts/fiddle_wrapper (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/scri...
experimental/webtry/scripts/fiddle_wrapper:18: ./fiddle_run $1
On 2014/10/01 16:39:50, jcgregorio wrote:
> fiddle_gyp, fiddle_ninja, and fiddle_run all need short comments in them to
look
> at this file to see how they are used.

Done.

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
File experimental/webtry/setup/continue_install.sh (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
experimental/webtry/setup/continue_install.sh:20: wget
https://go.googlecode.com/files/go1.2.1.linux-amd64.tar.gz
On 2014/10/01 16:39:50, jcgregorio wrote:
> Can we upgrade to 1.3.3?

I don't see why not.

Done.

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
File experimental/webtry/setup/continue_install_jail.sh (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
experimental/webtry/setup/continue_install_jail.sh:6: umount /dev/shm
On 2014/10/01 16:39:50, jcgregorio wrote:
> Add a comment about what's going on here with the umount/mount.

Actually the umount was only really needed while I was testing this; I'll remove
it.

Comment still useful, though.

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
File experimental/webtry/setup/webtry_setup.sh (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/setu...
experimental/webtry/setup/webtry_setup.sh:36: # skia and depot_tools.  we split
up the installation process into
On 2014/10/01 16:39:50, jcgregorio wrote:
> We

Done.

LOL that you guys missed the gigantic comment at the bottom :)

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/webt...
File experimental/webtry/webtry.go (right):

https://codereview.chromium.org/619943002/diff/20001/experimental/webtry/webt...
experimental/webtry/webtry.go:819: //cmd := hash + " --out " + hash + ".png"
On 2014/10/01 16:39:50, jcgregorio wrote:
> commented out code?

Whoops!  jumped the gun and failed to add support for source images.  Will fix
in next patch; stay tuned.

[tfarina, 2014-10-01 17:57:25]

https://codereview.chromium.org/619943002/diff/40001/experimental/webtry/setu...
File experimental/webtry/setup/continue_install.sh (right):

https://codereview.chromium.org/619943002/diff/40001/experimental/webtry/setu...
experimental/webtry/setup/continue_install.sh:20: wget
https://storage.googleapis.com/golang/go1.3.3.linux-amd64.tar.gz
That isn't going to have any effect after the first install I think.

Because after we install 'go' for the first time, the if above will be true and
we will never get here and thus we won't upgrade from 1.2 to 1.3.

I think we need to check the version installed somehow. Or am I missing
something?

https://codereview.chromium.org/619943002/diff/40001/experimental/webtry/setu...
experimental/webtry/setup/continue_install.sh:24: mkdir ${HOME}/golib
thanks!

lgtm

[humper, 2014-10-01 19:03:09]

ptal. source images now working.

[jcgregorio, 2014-10-01 20:30:39]

On 2014/10/01 19:03:09, humper wrote:
> ptal. source images now working.

LGTM

[humper, 2014-10-01 21:06:53]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-10-01 21:07:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619943002/80001

[commit-bot: I haz the power, 2014-10-01 21:27:36]

Committed patchset #5 (id:80001) as b77955e1b1b94f5a472b4f5fc620d5dc83425a1f