Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 619903005: fix imul(reg, op, imm) emission on x64 (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

fix imul(reg, op, imm) emission on x64 R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24395

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M src/x64/assembler-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-02 09:56:19 UTC) #2
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-02 12:02:05 UTC) #3
dcarney
6 years, 2 months ago (2014-10-02 12:22:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698