Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 619903003: Turn off telemetry tests which crash on WebView (Closed)

Created:
6 years, 2 months ago by hjd
Modified:
6 years, 2 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Turn off telemetry tests which crash on WebView To move the WebView telemetry bot off hard coding which tests to use and start getting the list of tests automatically we need to label which tests don't work on the WebView. Bug tracking enabling them here: crbug.com/419687 BUG=391488, 419687 Committed: https://crrev.com/dc445f21b0f8b8aedca3331abe9966970c669856 Cr-Commit-Position: refs/heads/master@{#297827}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add bug numbers inline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/perf/benchmarks/blink_perf.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/media.py View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
hjd
ptal
6 years, 2 months ago (2014-10-01 18:13:31 UTC) #2
Sami
Do we have bugs filed for the failing tests? https://codereview.chromium.org/619903003/diff/1/tools/perf/benchmarks/blink_perf.py File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/619903003/diff/1/tools/perf/benchmarks/blink_perf.py#newcode98 tools/perf/benchmarks/blink_perf.py:98: ...
6 years, 2 months ago (2014-10-01 18:22:13 UTC) #3
hjd
...and that is why I shouldn't upload reviews just before leaving, sorry about that. I've ...
6 years, 2 months ago (2014-10-02 11:05:26 UTC) #4
Sami
Thanks. Could you add links to the bugs next to the disabling annotations too please.
6 years, 2 months ago (2014-10-02 11:18:57 UTC) #5
hjd
On 2014/10/02 11:18:57, Sami wrote: > Thanks. Could you add links to the bugs next ...
6 years, 2 months ago (2014-10-02 11:26:29 UTC) #6
Sami
Great, lgtm!
6 years, 2 months ago (2014-10-02 12:18:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619903003/20001
6 years, 2 months ago (2014-10-02 12:24:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619903003/20001
6 years, 2 months ago (2014-10-02 13:19:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as fef8adb31c25c8e1ce4848d615688dd7c4888c3a
6 years, 2 months ago (2014-10-02 14:23:46 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 14:24:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc445f21b0f8b8aedca3331abe9966970c669856
Cr-Commit-Position: refs/heads/master@{#297827}

Powered by Google App Engine
This is Rietveld 408576698