Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: src/IceTranslator.cpp

Issue 619893002: Subzero: Auto-awesome iterators. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTranslator.cpp
diff --git a/src/IceTranslator.cpp b/src/IceTranslator.cpp
index 91dcfd4de08bea8a02c5aa1a1411a001462d15f2..4ca342e12aca9ced961ee46e6c9dc0b7e2bd2d51 100644
--- a/src/IceTranslator.cpp
+++ b/src/IceTranslator.cpp
@@ -56,19 +56,15 @@ void Translator::nameUnnamedGlobalAddresses(llvm::Module *Mod) {
Ostream &errs = Ctx->getStrDump();
if (!GlobalPrefix.empty()) {
uint32_t NameIndex = 0;
- for (llvm::Module::global_iterator I = Mod->global_begin(),
- E = Mod->global_end();
- I != E; ++I) {
+ for (auto I = Mod->global_begin(), E = Mod->global_end(); I != E; ++I)
setValueName(I, "global", GlobalPrefix, NameIndex, errs);
- }
}
const IceString &FunctionPrefix = Flags.DefaultFunctionPrefix;
if (FunctionPrefix.empty())
return;
uint32_t NameIndex = 0;
- for (llvm::Module::iterator I = Mod->begin(), E = Mod->end(); I != E; ++I) {
- setValueName(I, "function", FunctionPrefix, NameIndex, errs);
- }
+ for (auto &I : *Mod)
+ setValueName(&I, "function", FunctionPrefix, NameIndex, errs);
}
void Translator::translateFcn(Cfg *Fcn) {
@@ -98,9 +94,7 @@ void Translator::emitConstants() {
void Translator::convertGlobals(llvm::Module *Mod) {
llvm::OwningPtr<TargetGlobalInitLowering> GlobalLowering(
TargetGlobalInitLowering::createLowering(Ctx->getTargetArch(), Ctx));
- for (llvm::Module::const_global_iterator I = Mod->global_begin(),
- E = Mod->global_end();
- I != E; ++I) {
+ for (auto I = Mod->global_begin(), E = Mod->global_end(); I != E; ++I) {
if (!I->hasInitializer())
continue;
const llvm::Constant *Initializer = I->getInitializer();
« src/IceCfg.cpp ('K') | « src/IceTimerTree.cpp ('k') | src/IceTypeConverter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698