cc: Make separate interface for BeginFrame ipc from OutputSurface

content/renderer/gpu/compositor_external_begin_frame_source.cc

Index: content/renderer/gpu/compositor_external_begin_frame_source.cc
diff --git a/content/renderer/gpu/compositor_external_begin_frame_source.cc b/content/renderer/gpu/compositor_external_begin_frame_source.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6d7952d57982aaf6dc3a5cafa9e2cffa32ba6854
--- /dev/null
+++ b/content/renderer/gpu/compositor_external_begin_frame_source.cc
@@ -0,0 +1,82 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/gpu/compositor_external_begin_frame_source.h"
+
+#include "content/common/view_messages.h"
+#include "content/renderer/render_thread_impl.h"
+#include "ipc/ipc_forwarding_message_filter.h"
+#include "ipc/ipc_sync_channel.h"
+#include "ipc/ipc_sync_message_filter.h"
+
+namespace content {
+
+// static
+IPC::ForwardingMessageFilter* CompositorExternalBeginFrameSource::CreateFilter(
+    base::TaskRunner* target_task_runner) {
+  uint32 messages_to_filter[] = {
+    ViewMsg_BeginFrame::ID
+  };
+
+  return new IPC::ForwardingMessageFilter(
+      messages_to_filter, arraysize(messages_to_filter),
+      target_task_runner);
+}
+
+CompositorExternalBeginFrameSource::CompositorExternalBeginFrameSource(
+    int routing_id)
+    : begin_frame_source_filter_(
+          RenderThreadImpl::current()->begin_frame_source_filter()),
+      message_sender_(RenderThreadImpl::current()->sync_message_filter()),
+      is_client_ready_(false),
+      routing_id_(routing_id) {
+  DCHECK(begin_frame_source_filter_.get());
+  DCHECK(message_sender_.get());
+  DetachFromThread();
+}
+
+CompositorExternalBeginFrameSource::~CompositorExternalBeginFrameSource() {
+  DCHECK(CalledOnValidThread());
+  if (begin_frame_source_proxy_.get())
+    begin_frame_source_proxy_->ClearBeginFrameSource();
+  begin_frame_source_filter_->RemoveRoute(routing_id_);
+}
+
+void CompositorExternalBeginFrameSource::OnNeedsBeginFramesChange(
+    bool needs_begin_frames) {
+  DCHECK(CalledOnValidThread());
+  Send(new ViewHostMsg_SetNeedsBeginFrame(routing_id_, needs_begin_frames));

[danakj, 2014/10/10 16:03:35]

What's sending us here on shutdown now? Do we need to get here still?
ThreadProxy used to call SetNeedsBeginFrames(false) (which of course wouldn't
work in a single threaded scheduler world, heh).

[simonhong, 2014/10/15 01:04:21]

I made cc::Scheduler call SentNeedsBeginFrames(false) in its dtor.

+}
+
+void CompositorExternalBeginFrameSource::SetClientReady() {
+  DCHECK(CalledOnValidThread());
+  is_client_ready_ = true;
+  begin_frame_source_proxy_ =
+      new CompositorExternalBeginFrameSourceProxy(this);
+  begin_frame_source_filter_->AddRoute(
+      routing_id_,
+      base::Bind(&CompositorExternalBeginFrameSourceProxy::OnMessageReceived,
+                 begin_frame_source_proxy_));
+}
+
+void CompositorExternalBeginFrameSource::OnMessageReceived(
+    const IPC::Message& message) {
+  DCHECK(CalledOnValidThread());
+  DCHECK(is_client_ready_);
+  IPC_BEGIN_MESSAGE_MAP(CompositorExternalBeginFrameSource, message)
+    IPC_MESSAGE_HANDLER(ViewMsg_BeginFrame, OnBeginFrame);
+  IPC_END_MESSAGE_MAP();
+}
+
+void CompositorExternalBeginFrameSource::OnBeginFrame(
+  const cc::BeginFrameArgs& args) {
+  DCHECK(CalledOnValidThread());
+  CallOnBeginFrame(args);
+}
+
+bool CompositorExternalBeginFrameSource::Send(IPC::Message* message) {
+  return message_sender_->Send(message);
+}
+
+}  // namespace content