cc: Make separate interface for BeginFrame ipc from OutputSurface

content/browser/android/in_process/synchronous_compositor_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/in_process/synchronous_compositor_impl.h"
 
+#include "base/auto_reset.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop/message_loop.h"
 #include "cc/input/input_handler.h"
+#include "content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h"
 #include "content/browser/android/in_process/synchronous_compositor_factory_impl.h"
 #include "content/browser/android/in_process/synchronous_input_event_filter.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 #include "content/common/input/did_overscroll_params.h"
 #include "content/public/browser/android/synchronous_compositor_client.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "ui/gl/gl_surface.h"
 
@@ skipping 38 matching lines @@
 }
 
 SynchronousCompositorImpl* SynchronousCompositorImpl::FromRoutingID(
     int routing_id) {
   return FromID(GetInProcessRendererId(), routing_id);
 }
 
 SynchronousCompositorImpl::SynchronousCompositorImpl(WebContents* contents)
     : compositor_client_(NULL),
       output_surface_(NULL),
+      begin_frame_source_(NULL),
       contents_(contents),
       input_handler_(NULL),
+      invoking_composite_(false),
       weak_ptr_factory_(this) {
   DCHECK(contents);
 }
 
 SynchronousCompositorImpl::~SynchronousCompositorImpl() {
   if (compositor_client_)
     compositor_client_->DidDestroyCompositor(this);
   SetInputHandler(NULL);
 }
 
 void SynchronousCompositorImpl::SetClient(
     SynchronousCompositorClient* compositor_client) {
   DCHECK(CalledOnValidThread());
   compositor_client_ = compositor_client;
 }
 
 // static
 void SynchronousCompositor::SetGpuService(
     scoped_refptr<gpu::InProcessCommandBuffer::Service> service) {
   g_factory.Get().SetDeferredGpuService(service);
 }
 
 // static
 void SynchronousCompositor::SetRecordFullDocument(bool record_full_document) {
   g_factory.Get().SetRecordFullDocument(record_full_document);
 }
 
+void SynchronousCompositorImpl::SetExternalBeginFrameSource(
+    SynchronousCompositorExternalBeginFrameSource* begin_frame_source) {
+  begin_frame_source_ = begin_frame_source;

[boliu, 2014/10/24 17:42:40]

Need keep BeginFrameSource and compositor_client_ state in sync, ie call
compositor_client_->SetContinuousInvalidate(NeedsBeginFrames()); 

[simonhong, 2014/10/29 14:47:13]

DCHECK(compositor_client_) is added.
And, begin_frame_source_ is set to null when
DidDestroySynchronousOutputSurface() is called.

+}
+
 bool SynchronousCompositorImpl::InitializeHwDraw() {
   DCHECK(CalledOnValidThread());
   DCHECK(output_surface_);
 
   scoped_refptr<cc::ContextProvider> onscreen_context =
       g_factory.Get().CreateOnscreenContextProviderForCompositorThread();
 
   bool success = output_surface_->InitializeHwDraw(onscreen_context);
 
   if (success)
@@ skipping 10 matching lines @@
 
 scoped_ptr<cc::CompositorFrame> SynchronousCompositorImpl::DemandDrawHw(
     gfx::Size surface_size,
     const gfx::Transform& transform,
     gfx::Rect viewport,
     gfx::Rect clip,
     gfx::Rect viewport_rect_for_tile_priority,
     const gfx::Transform& transform_for_tile_priority) {
   DCHECK(CalledOnValidThread());
   DCHECK(output_surface_);
+  DCHECK(!invoking_composite_);
+  DCHECK(begin_frame_source_);

[boliu, 2014/10/24 17:42:40]

This DCHECK is not guaranteed.

Note we only call DidInitializeCompositor/DidDestroyCompositor while compositor
has an output surface.

Now this condition needs to be having an output surface *and* a begin frame
source.

[simonhong, 2014/10/29 14:47:13]

Removed.

+  base::AutoReset<bool> invoking_composite_resetter(&invoking_composite_, true);
 
   scoped_ptr<cc::CompositorFrame> frame =
       output_surface_->DemandDrawHw(surface_size,
                                     transform,
                                     viewport,
                                     clip,
                                     viewport_rect_for_tile_priority,
                                     transform_for_tile_priority);
   if (frame.get())
     UpdateFrameMetaData(frame->metadata);
 

[boliu, 2014/10/24 17:42:40]

Where is the BeginFrame and SetContinuousInvalidate calls here?

[simonhong, 2014/10/29 14:47:13]

SetContinuousInvalidate() is added.

   return frame.Pass();
 }
 
+void SynchronousCompositorImpl::RequestBeginFrame() {

[boliu, 2014/10/24 17:42:40]

Super confusing name, should be just BeginFrame. But this shouldn't exist at
all.

[simonhong, 2014/10/29 14:47:13]

This function is removed.

+  begin_frame_source_->BeginFrame();

[boliu, 2014/10/24 17:42:40]

DCHECK(begin_frame_source_)

+  SetContinuousInvalidate(begin_frame_source_->NeedsBeginFrames());

[boliu, 2014/10/24 17:42:40]

Why?

+}
+
 void SynchronousCompositorImpl::ReturnResources(
     const cc::CompositorFrameAck& frame_ack) {
   DCHECK(CalledOnValidThread());
   output_surface_->ReturnResources(frame_ack);
 }
 
 bool SynchronousCompositorImpl::DemandDrawSw(SkCanvas* canvas) {
   DCHECK(CalledOnValidThread());
   DCHECK(output_surface_);
+  DCHECK(!invoking_composite_);
+  DCHECK(begin_frame_source_);
+  base::AutoReset<bool> invoking_composite_resetter(&invoking_composite_, true);
 
   scoped_ptr<cc::CompositorFrame> frame = output_surface_->DemandDrawSw(canvas);
   if (frame.get())
     UpdateFrameMetaData(frame->metadata);
+
+  begin_frame_source_->BeginFrame();

[boliu, 2014/10/24 17:42:40]

Why?

[simonhong, 2014/10/29 14:47:13]

Removed.

+  SetContinuousInvalidate(begin_frame_source_->NeedsBeginFrames());
+
   return !!frame.get();
 }
 
 void SynchronousCompositorImpl::UpdateFrameMetaData(
     const cc::CompositorFrameMetadata& frame_metadata) {
   RenderWidgetHostViewAndroid* rwhv = static_cast<RenderWidgetHostViewAndroid*>(
       contents_->GetRenderWidgetHostView());
   if (rwhv)
     rwhv->SynchronousFrameMetadata(frame_metadata);
   DeliverMessages();
@@ skipping 56 matching lines @@
   }
 }
 
 void SynchronousCompositorImpl::DidStopFlinging() {
   RenderWidgetHostViewAndroid* rwhv = static_cast<RenderWidgetHostViewAndroid*>(
       contents_->GetRenderWidgetHostView());
   if (rwhv)
     rwhv->DidStopFlinging();
 }
 
-void SynchronousCompositorImpl::SetContinuousInvalidate(bool enable) {
+void SynchronousCompositorImpl::SetContinuousInvalidate(
+    bool needs_begin_frames) const {
   DCHECK(CalledOnValidThread());
   if (compositor_client_)
-    compositor_client_->SetContinuousInvalidate(enable);
+    compositor_client_->SetContinuousInvalidate(needs_begin_frames);

[boliu, 2014/10/24 17:42:40]

We want to hold off on this if invoking_composite_ is true.

[simonhong, 2014/10/29 14:47:13]

Made early out if invoking_composite_ is true.

 }
 
 InputEventAckState SynchronousCompositorImpl::HandleInputEvent(
     const blink::WebInputEvent& input_event) {
   DCHECK(CalledOnValidThread());
   return g_factory.Get().synchronous_input_event_filter()->HandleInputEvent(
       contents_->GetRoutingID(), input_event);
 }
 
 void SynchronousCompositorImpl::DeliverMessages() {
@@ skipping 66 matching lines @@
     g_factory.Get();  // Ensure it's initialized.
     SynchronousCompositorImpl::CreateForWebContents(contents);
   }
   if (SynchronousCompositorImpl* instance =
       SynchronousCompositorImpl::FromWebContents(contents)) {
     instance->SetClient(client);
   }
 }
 
 }  // namespace content