Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2544)

Unified Diff: base/metrics/statistics_recorder.h

Issue 61983003: Add a switch to emit browser histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more review comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/statistics_recorder.cc » ('j') | base/metrics/statistics_recorder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/statistics_recorder.h
diff --git a/base/metrics/statistics_recorder.h b/base/metrics/statistics_recorder.h
index 0fdfb7698de150248d9dac461d64f417553dc8ac..936aef08036d5b97f456ffed313da2af8d1c10cf 100644
--- a/base/metrics/statistics_recorder.h
+++ b/base/metrics/statistics_recorder.h
@@ -49,12 +49,15 @@ class BASE_EXPORT StatisticsRecorder {
static const BucketRanges* RegisterOrDeleteDuplicateRanges(
const BucketRanges* ranges);
- // Methods for printing histograms. Only histograms which have query as
- // a substring are written to output (an empty string will process all
- // registered histograms).
+ // Methods for appending histogram data to a string. Only histograms which
+ // have |query| as a substring are written to |output| (an empty string will
+ // process all registered histograms).
static void WriteHTMLGraph(const std::string& query, std::string* output);
static void WriteGraph(const std::string& query, std::string* output);
+ // Returns the histograms with |query| as a substring as JSON text.
Peter Kasting 2013/11/14 07:04:06 Nit: Maybe should add "(as in Write[HTML]Graph abo
grt (UTC plus 2) 2013/11/14 14:44:12 Done.
+ static std::string ToJSON(const std::string& query);
+
// Method for extracting histograms which were marked for use by UMA.
static void GetHistograms(Histograms* output);
« no previous file with comments | « no previous file | base/metrics/statistics_recorder.cc » ('j') | base/metrics/statistics_recorder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698