Issue 619773002: Remove ToS strings on Android.

Issue 619773002: Remove ToS strings on Android. (Closed)

Created:
6 years, 2 months ago by newt (away)

Modified:
6 years, 2 months ago

Reviewers:
aruslan, Evan Stade

CC:
chromium-reviews, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove ToS strings on Android. The terms of service are now loaded from a URL instead of being packaged in the APK. BUG=416002 Committed: https://crrev.com/85222ebfe7195a25e6d4c89ea51146de46a86e12 Cr-Commit-Position: refs/heads/master@{#297554}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -31 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java	View	1 chunk	+2 lines, -17 lines	0 comments	Download
M	chrome/app/resources/locale_settings.grd	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/browser_version.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/about_ui.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

aruslan

lgtm w/exception of webui fancy nesting of #if -- that's up to estade :)

6 years, 2 months ago (2014-09-30 21:53:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619773002/1

6 years, 2 months ago (2014-09-30 23:18:35 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as c4db74d3449172e149c48b331b2fb3b2cb3d0489

6 years, 2 months ago (2014-10-01 00:05:58 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-01 00:07:15 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/85222ebfe7195a25e6d4c89ea51146de46a86e12
Cr-Commit-Position: refs/heads/master@{#297554}