Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 619763005: Release nonsfi_loader as a part of NaCl SDK (Closed)

Created:
6 years, 2 months ago by hamaji
Modified:
6 years, 2 months ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Release nonsfi_loader as a part of NaCl SDK TEST=./build_tools/build_sdk.py --tar TEST=trybot BUG= https://code.google.com/p/nativeclient/issues/detail?id=3851 Committed: https://crrev.com/4d482d28b3884c1637eb9e0ea572d218b14fd088 Cr-Commit-Position: refs/heads/master@{#300065}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hamaji
PTAL
6 years, 2 months ago (2014-10-15 12:27:27 UTC) #2
Sam Clegg
please run the sdk trybots (they should be part of the default set, but they ...
6 years, 2 months ago (2014-10-15 17:28:43 UTC) #3
hamaji
Thanks for the review! Sorry I forgot to run trybots. https://codereview.chromium.org/619763005/diff/70001/native_client_sdk/src/build_tools/sdk_files.list File native_client_sdk/src/build_tools/sdk_files.list (right): https://codereview.chromium.org/619763005/diff/70001/native_client_sdk/src/build_tools/sdk_files.list#newcode441 ...
6 years, 2 months ago (2014-10-16 10:08:15 UTC) #4
Sam Clegg
lgtm
6 years, 2 months ago (2014-10-16 17:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619763005/90001
6 years, 2 months ago (2014-10-17 04:47:36 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:90001)
6 years, 2 months ago (2014-10-17 04:58:33 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 04:59:42 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4d482d28b3884c1637eb9e0ea572d218b14fd088
Cr-Commit-Position: refs/heads/master@{#300065}

Powered by Google App Engine
This is Rietveld 408576698