Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: gpu/command_buffer/service/program_manager.h

Issue 619723008: Switch to use ANGLE's new APIs to query shader variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win build fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/mocks.h ('k') | gpu/command_buffer/service/program_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/program_manager.h
diff --git a/gpu/command_buffer/service/program_manager.h b/gpu/command_buffer/service/program_manager.h
index bcc3630f104bd9d9e93d8b62c34cbc24b0853745..b9a169734d2336aff362ef9dafd33d44527d87ff 100644
--- a/gpu/command_buffer/service/program_manager.h
+++ b/gpu/command_buffer/service/program_manager.h
@@ -79,7 +79,7 @@ class GPU_EXPORT Program : public base::RefCounted<Program> {
};
struct VertexAttrib {
VertexAttrib(GLsizei _size, GLenum _type, const std::string& _name,
- GLint _location)
+ GLint _location)
: size(_size),
type(_type),
location(_location),
@@ -281,9 +281,17 @@ class GPU_EXPORT Program : public base::RefCounted<Program> {
const std::string& name, const std::string& original_name,
size_t* next_available_index);
- void GetCorrectedVariableInfo(
- bool use_uniforms, const std::string& name, std::string* corrected_name,
- std::string* original_name, GLsizei* size, GLenum* type) const;
+ // Query uniform data returned by ANGLE translator by the mapped name.
+ // Some drivers incorrectly return an uniform name of size-1 array without
+ // "[0]". In this case, we correct the name by appending "[0]" to it.
+ void GetCorrectedUniformData(
+ const std::string& name,
+ std::string* corrected_name, std::string* original_name,
+ GLsizei* size, GLenum* type) const;
+
+ // Query VertexAttrib data returned by ANGLE translator by the mapped name.
+ void GetVertexAttribData(
+ const std::string& name, std::string* original_name, GLenum* type) const;
void DetachShaders(ShaderManager* manager);
« no previous file with comments | « gpu/command_buffer/service/mocks.h ('k') | gpu/command_buffer/service/program_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698