Issue 619723006: Instrumented libraries: remove unnecessary uses of DEPTH from GYP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 619723006: Instrumented libraries: remove unnecessary uses of DEPTH from GYP. (Closed)

Created:
6 years, 2 months ago by earthdok

Modified:
6 years, 2 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, pbos, kjellander_chromium

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Instrumented libraries: remove unnecessary uses of DEPTH from GYP. This was not working correctly in WebRTC builds. Also, add -fno-omit-frame-pointer to CFLAGS. Both changes will cause a complete rebuild of all instrumented libraries, so I bundled them together. BUG=394251 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/138ba3ed4f3a93e7bab569aa9d2e3ff4ff4fe5a5 Cr-Commit-Position: refs/heads/master@{#297652}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	third_party/instrumented_libraries/instrumented_libraries.gyp	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	third_party/instrumented_libraries/standard_instrumented_package_target.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619723006/1

6 years, 2 months ago (2014-10-01 15:52:16 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as 948a28e409297d0aa9d102d3704a4bd93e1b9f6e

6 years, 2 months ago (2014-10-01 15:53:23 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/138ba3ed4f3a93e7bab569aa9d2e3ff4ff4fe5a5 Cr-Commit-Position: refs/heads/master@{#297652}

6 years, 2 months ago (2014-10-01 15:54:04 UTC) #5

Message was sent while issue was closed.

rubberstamp LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages