Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 619683002: Reenable MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead test. (Closed)

Created:
6 years, 2 months ago by Oren Blasberg
Modified:
6 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, extensions-reviews_chromium.org, vandebo (ex-Chrome), tommycli, Greg Billock, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reenable MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead test. It's no longer flaky since the underlying bug was fixed in crrev.com/615633003. BUG=415792 Committed: https://crrev.com/5689fdb4d43581749d0071e5dbf417b782424520 Cr-Commit-Position: refs/heads/master@{#297764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Oren Blasberg
I won't commit this until the bug fix is committed too. Just wanted to get ...
6 years, 2 months ago (2014-09-30 16:48:25 UTC) #2
Oren Blasberg
Bug fix got committed so this should be ok now.
6 years, 2 months ago (2014-09-30 18:55:03 UTC) #3
tommycli
LGTM
6 years, 2 months ago (2014-10-01 21:56:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619683002/1
6 years, 2 months ago (2014-10-01 21:58:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/18176)
6 years, 2 months ago (2014-10-02 00:07:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619683002/1
6 years, 2 months ago (2014-10-02 00:24:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 69059e6100978c6cd186cc58814a3044ba12615e
6 years, 2 months ago (2014-10-02 02:01:34 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 02:02:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5689fdb4d43581749d0071e5dbf417b782424520
Cr-Commit-Position: refs/heads/master@{#297764}

Powered by Google App Engine
This is Rietveld 408576698