LayoutTests/fast/events/keydown-enter-key-on-focused-element-inside-link.html - Issue 619613005: The link should be activated by enter key on focusing the child element inside the anchor(relanding)

Side by Side Diff: LayoutTests/fast/events/keydown-enter-key-on-focused-element-inside-link.html

Issue 619613005: The link should be activated by enter key on focusing the child element inside the anchor(relanding) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	robwu 2014/10/13 09:19:48 This file should be renamed to "keypress-enter.... This file should be renamed to "keypress-enter....", or (more genericly and implementation-independent) "press-enter-...". Miyoung Shin(g) 2014/10/13 11:05:01 Oh, right, I will change it Show quoted text On 2014/10/13 09:19:48, robwu wrote: > This file should be renamed to "keypress-enter....", or (more genericly and > implementation-independent) "press-enter-...". Oh, right, I will change it
	2 <script src="../../resources/js-test.js"></script>

	3 <a id="link" href="#" tabindex="-1" onclick="checkKeyEvent(event)">

	4 <h1 tabindex="1">EnterMe</h1>

	5 </a>

	6 <div id="console"></div>

	7 <script>

	8 description("This test ensures that the link is activated by enter key on fo cusing the child element inside the anchor");

	9

	10 var i = 0;

	11 function test() {

	12 if (window.eventSender)

	13 eventSender.keyDown('\t');

	14 var event = document.createEvent("KeyboardEvents");

	15 event.initKeyboardEvent("keypress", true, true, window, "Enter", 0, 0, 0 , 0, 0, false);

	16 document.activeElement.dispatchEvent(event);
	robwu 2014/10/13 09:19:48 You should also be simulating the keydown/keyup ev You should also be simulating the keydown/keyup events to model a realistic situation. Just use eventSender.keyDown('\r'); - this will simulate a keydown, keypress and keyup event. Miyoung Shin(g) 2014/10/13 11:05:01 OK. I will add keydown/keyup as well Show quoted text On 2014/10/13 09:19:48, robwu wrote: > You should also be simulating the keydown/keyup events to model a realistic > situation. OK. I will add keydown/keyup as well Show quoted text > Just use eventSender.keyDown('\r'); - this will simulate a keydown, keypress and > keyup event. I couldn't, because keypress event doesn't get keycode when I use eventSender.keyDown('\r');, because there is the code to reset the keycode of '\r'in implemenation of eventSender.keyDown() robwu 2014/10/13 11:29:32 The test code in the following files suggest that Show quoted text On 2014/10/13 11:05:01, Miyoung Shin(g) wrote: > On 2014/10/13 09:19:48, robwu wrote: > > You should also be simulating the keydown/keyup events to model a realistic > > situation. > > OK. I will add keydown/keyup as well > > > Just use eventSender.keyDown('\r'); - this will simulate a keydown, keypress > and > > keyup event. > > I couldn't, because keypress event doesn't get keycode when I use > eventSender.keyDown('\r');, > because there is the code to reset the keycode of '\r'in implemenation of > eventSender.keyDown() The test code in the following files suggest that Enter+keydown/keypress (implying Enter) is correctly supported (on buttons) src/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html src/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button-expected.txt
	17 }

	18 function checkKeyEvent(event) {

	19 debug("PASS : [" + document.activeElement.localName + "], link is activa ted")

	20 }

	21 test();

	22 </script>

OLD	NEW