Debug a mystery crash bug in script streaming.

Debug a mystery crash bug in script streaming.

This adds a bunch of checks so we hopefully get more detailed information about
what exactly goes wrong.

R=jochen@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=24373

[marja, 2014-10-01 13:26:13]

jochen, ptal.

[jochen (gone - plz use gerrit), 2014-10-01 14:03:03]

lgtm

https://codereview.chromium.org/619583005/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/619583005/diff/1/src/parser.cc#newcode3710
src/parser.cc:3710: CHECK(materialized_literal_count != NULL);
nit. just CHECK(materialized_literal_count); and below

[marja, 2014-10-01 15:59:35]

t

https://codereview.chromium.org/619583005/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/619583005/diff/1/src/parser.cc#newcode3710
src/parser.cc:3710: CHECK(materialized_literal_count != NULL);
On 2014/10/01 14:03:03, jochen wrote:
> nit. just CHECK(materialized_literal_count); and below

Done.

Grumble grumble, so we really do

if (foo != NULL) { ... }

but

CHECK(foo);

That is confusing.

[marja, 2014-10-01 16:54:58]

Committed patchset #2 (id:20001) manually as 24373 (presubmit successful).