Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 619563003: Archive SkFloat (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
tfarina, mtklein, reed1
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Archive SkFloat https://crrev.com/610153002/ reminded me that it existed, but it's entirely unused and made moot by hardware FP. Might as well trim a few K off libskia. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1b466f7e21004257afeb35cd008768e3b541dca9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -497 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D src/core/SkFloat.h View 1 chunk +0 lines, -107 lines 0 comments Download
D src/core/SkFloat.cpp View 1 chunk +0 lines, -387 lines 0 comments Download
M src/core/SkGraphics.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein
6 years, 2 months ago (2014-09-30 14:09:57 UTC) #2
tfarina
lgtm
6 years, 2 months ago (2014-09-30 14:22:17 UTC) #4
reed1
(snif snif) goodbye software float, it was fun while it lasted. lgtm
6 years, 2 months ago (2014-09-30 14:58:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619563003/1
6 years, 2 months ago (2014-09-30 15:00:36 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 15:09:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 1b466f7e21004257afeb35cd008768e3b541dca9

Powered by Google App Engine
This is Rietveld 408576698