Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 619563002: Revert of Refactor FakeAttachmentStore (Closed)

Created:
6 years, 2 months ago by sergeyv
Modified:
6 years, 2 months ago
Reviewers:
maniscalco, pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor FakeAttachmentStore (patchset #3 id:40001 of https://codereview.chromium.org/601553004/) Reason for revert: Speculative revert: looks like it causes failures on the Linux asan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/8113 Original issue's description: > Refactor FakeAttachmentStore > > Refactor FakeAttachmentStore into AttachmentStoreProxy and > InMemoryAttachmentStore backend. Break AttachmentStore interface into > AttachmentStoreBase (common interface for backends) and AttachmentStore > (referenced by datatype and AttachmentService). > > BUG= > R=maniscalco@chromium.org > > Committed: https://crrev.com/6ae2b341c73909cf902078446346d6c900273409 > Cr-Commit-Position: refs/heads/master@{#297339} TBR=maniscalco@chromium.org,pavely@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/198e717d6d35439d59c71519910e7b14c56f8282 Cr-Commit-Position: refs/heads/master@{#297379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -719 lines) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/BUILD.gn View 4 chunks +8 lines, -11 lines 0 comments Download
M sync/api/attachments/attachment_store.h View 3 chunks +4 lines, -18 lines 0 comments Download
M sync/api/attachments/attachment_store.cc View 1 chunk +0 lines, -15 lines 0 comments Download
A sync/api/attachments/fake_attachment_store.h View 1 chunk +60 lines, -0 lines 0 comments Download
A sync/api/attachments/fake_attachment_store.cc View 1 chunk +128 lines, -0 lines 0 comments Download
A sync/api/attachments/fake_attachment_store_unittest.cc View 1 chunk +257 lines, -0 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D sync/internal_api/attachments/attachment_store_handle.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D sync/internal_api/attachments/attachment_store_handle_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D sync/internal_api/attachments/in_memory_attachment_store.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D sync/internal_api/attachments/in_memory_attachment_store_unittest.cc View 1 chunk +0 lines, -259 lines 0 comments Download
D sync/internal_api/public/attachments/attachment_store_handle.h View 1 chunk +0 lines, -66 lines 0 comments Download
D sync/internal_api/public/attachments/in_memory_attachment_store.h View 1 chunk +0 lines, -43 lines 0 comments Download
M sync/sync.gyp View 3 chunks +8 lines, -10 lines 0 comments Download
M sync/sync_tests.gypi View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
Created Revert of Refactor FakeAttachmentStore
6 years, 2 months ago (2014-09-30 07:47:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619563002/1
6 years, 2 months ago (2014-09-30 07:48:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4584be1e64e5a07181fe931203953163986cc8b4
6 years, 2 months ago (2014-09-30 07:48:50 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 07:50:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/198e717d6d35439d59c71519910e7b14c56f8282
Cr-Commit-Position: refs/heads/master@{#297379}

Powered by Google App Engine
This is Rietveld 408576698