Hook up custom Win 64 SEH to v8

components/crash/app/breakpad_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/app/breakpad_win.h"
 
 #include <windows.h>
 #include <shellapi.h>
 #include <tchar.h>
 #include <userenv.h>
@@ skipping 593 matching lines @@
 // restarted instance will still contain the pipe environment variable, which
 // will allow the restarted process to still upload crash reports. This function
 // clears the environment variable, so that the restarted Chrome, which inherits
 // its environment from the current Chrome, will no longer contain the variable.
 extern "C" void __declspec(dllexport) __cdecl
       ClearBreakpadPipeEnvironmentVariable() {
   scoped_ptr<base::Environment> env(base::Environment::Create());
   env->UnSetVar(kPipeNameVar);
 }
 
+#ifdef _WIN64
+PRUNTIME_FUNCTION GetRuntimeFunctionCallback(DWORD64 ControlPC, PVOID Context) {
+  if (g_breakpad) {

[cpu_(ooo_6.6-7.5), 2014/09/30 19:20:49]

why not call here CrashForException() ?

[jochen (gone - plz use gerrit), 2014/09/30 19:23:26]

i don't have exception pointers.

I could create a runtime function with unwind info that has CrashForException as
exception handler, but the unwind info needs to be in the same memory range as
the crash that occurred :-/ which i can't generally write to

+    g_breakpad->WriteMinidump();
+    // Patched stub exists based on conditions (See InitCrashReporter).
+    // As a side note this function also gets called from
+    // WindowProcExceptionFilter.
+    if (g_real_terminate_process_stub == NULL) {
+      ::TerminateProcess(::GetCurrentProcess(), content::RESULT_CODE_KILLED);
+    } else {
+      NtTerminateProcessPtr real_terminate_proc =
+          reinterpret_cast<NtTerminateProcessPtr>(
+              static_cast<char*>(g_real_terminate_process_stub));
+      real_terminate_proc(::GetCurrentProcess(), content::RESULT_CODE_KILLED);
+    }
+  }
+  return NULL;
+}
+
+extern "C" void __declspec(dllexport) __cdecl
+RegisterNonABICompliantCodeRange(void* start, size_t size_in_bytes) {
+  RtlInstallFunctionTableCallback(
+      reinterpret_cast<DWORD64>(start) | 0x3,

[cpu_(ooo_6.6-7.5), 2014/09/30 19:20:49]

or 3 ?

this needs a comment.

[jochen (gone - plz use gerrit), 2014/09/30 19:23:26]

well, because that's what the API says. First parameter should be the address |
0x3, second parameter should be the address. what else would you expect?

+      reinterpret_cast<DWORD64>(start),
+      static_cast<DWORD>(size_in_bytes),
+      GetRuntimeFunctionCallback,
+      NULL,
+      NULL);
+}
+#endif
+
 }  // namespace breakpad