Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 619523003: Add compiled_resources.gyp for file_manager/*. (Closed)

Created:
6 years, 2 months ago by fukino
Modified:
6 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add compiled_resources.gyp for file_manager/*. As a start, I added compiled_resources.gyp for each components in file_manager. BUG=406995 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/background/js/compiled_resources.gyp && ninja -C out/Default GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/video_player/js/compiled_resources.gyp && ninja -C out/Default GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/image_loader/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/88bf4dda77fd4aef433b49b3c58348275fa1fc82 Cr-Commit-Position: refs/heads/master@{#297390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -3 lines) Patch
A ui/file_manager/file_manager/background/js/compiled_resources.gyp View 1 chunk +35 lines, -0 lines 0 comments Download
A ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +41 lines, -0 lines 0 comments Download
A + ui/file_manager/image_loader/compiled_resources.gyp View 1 chunk +8 lines, -3 lines 0 comments Download
A ui/file_manager/video_player/js/compiled_resources.gyp View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
yoshiki@, could you take a look? Thanks!
6 years, 2 months ago (2014-09-30 08:18:27 UTC) #2
yoshiki
lgtm
6 years, 2 months ago (2014-09-30 08:20:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619523003/1
6 years, 2 months ago (2014-09-30 08:27:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 103613dcdd94070b6fca8dd9dd59d0a1e73449ef
6 years, 2 months ago (2014-09-30 09:17:57 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 09:18:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88bf4dda77fd4aef433b49b3c58348275fa1fc82
Cr-Commit-Position: refs/heads/master@{#297390}

Powered by Google App Engine
This is Rietveld 408576698