Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 619473002: Skipping AX test related to input types (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Skipping AX test related to input types This AX tests are failing because chromium side dependancy is yet to be merged. BUG=418486 Committed: https://crrev.com/053089cc747d20e63f8e0059e47dc192dad92d35 Cr-Commit-Position: refs/heads/master@{#297384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/test/data/accessibility/input-time-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/input-types-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
shreeramk
Please review. This CL https://codereview.chromium.org/612063002/ has been reverted because input-time.html is failing on content_browsertest. Will ...
6 years, 2 months ago (2014-09-30 02:54:33 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-09-30 06:15:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619473002/1
6 years, 2 months ago (2014-09-30 06:16:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 536797a1717e97ba4f18f74124fb950ed3b107e5
6 years, 2 months ago (2014-09-30 08:47:25 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/053089cc747d20e63f8e0059e47dc192dad92d35 Cr-Commit-Position: refs/heads/master@{#297384}
6 years, 2 months ago (2014-09-30 08:48:15 UTC) #7
je_julie(Not used)
On 2014/09/30 08:48:15, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 2 months ago (2014-09-30 13:36:16 UTC) #8
shreeramk
6 years, 2 months ago (2014-09-30 14:30:04 UTC) #9
Message was sent while issue was closed.
On 2014/09/30 13:36:16, je_julie.kim wrote:
> On 2014/09/30 08:48:15, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/053089cc747d20e63f8e0059e47dc192dad92d35
> > Cr-Commit-Position: refs/heads/master@{#297384}
> 
> 
> Hi Shreeram,
> I just saw fail from input-time TC on MAC and Android.
> Don't you need to skip it on MAC and Android as well?

Yes. It has to. I thought with my change, the builds are only failing for Win. I
ll upload a patch right now.

Powered by Google App Engine
This is Rietveld 408576698