net/socket/ssl_client_socket_nss.cc - Issue 619463002: net: disable SSLv3 fallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 619463002: net: disable SSLv3 fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ... Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_nss.cc

diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc

index c5869fc3503a5ddfa53abb1b9ba0aecbabbfb442..826c94b03a777b30c844214534b449aa203a3cb7 100644

--- a/net/socket/ssl_client_socket_nss.cc

+++ b/net/socket/ssl_client_socket_nss.cc

@@ -3314,6 +3314,11 @@ int SSLClientSocketNSS::DoHandshakeComplete(int result) {

EnterFunction(result);

if (result == OK) {

+ if (ssl_config_.version_fallback &&

+ ssl_config_.version_max < ssl_config_.version_fallback_min) {

+ return ERR_SSL_FALLBACK_BEYOND_MINIMUM_VERSION;

+ }

// SSL handshake is completed. Let's verify the certificate.

GotoState(STATE_VERIFY_CERT);

// Done!