net/socket/ssl_client_socket_openssl.cc - Issue 619463002: net: disable SSLv3 fallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 619463002: net: disable SSLv3 fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ... Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_openssl.cc

diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc

index f341a9fc3775a60266d77f36e40babff29ea1ee9..324dac0b8e9a9efbb7c8520a073c6be994181f7a 100644

--- a/net/socket/ssl_client_socket_openssl.cc

+++ b/net/socket/ssl_client_socket_openssl.cc

@@ -907,6 +907,11 @@ int SSLClientSocketOpenSSL::DoHandshake() {

<< " is: " << (SSL_session_reused(ssl_) ? "Success" : "Fail");

}

+ if (ssl_config_.version_fallback &&

+ ssl_config_.version_max < ssl_config_.version_fallback_min) {

+ return ERR_SSL_NEEDS_MORE_FALLBACK;

+ }

// SSL handshake is completed. If NPN wasn't negotiated, see if ALPN was.

if (npn_status_ == kNextProtoUnsupported) {

const uint8_t* alpn_proto = NULL;