Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5249)

Unified Diff: chrome/common/localized_error.cc

Issue 619463002: net: disable SSLv3 fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ... Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/localized_error.cc
diff --git a/chrome/common/localized_error.cc b/chrome/common/localized_error.cc
index bfd0b5f30b11f2b73efcaf83bd456b3edf1b60ce..77450598912cf6da15c06135a8c901abc19f1b08 100644
--- a/chrome/common/localized_error.cc
+++ b/chrome/common/localized_error.cc
@@ -40,6 +40,8 @@ static const char kRedirectLoopLearnMoreUrl[] =
static const char kWeakDHKeyLearnMoreUrl[] =
"http://sites.google.com/a/chromium.org/dev/"
felt 2014/10/01 02:22:18 ^ while you're here, can you make that https?
"err_ssl_weak_server_ephemeral_dh_key";
+static const char kSSLv3FallbackUrl[] =
+ "https://code.google.com/p/chromium/issues/detail?id=418848";
#if defined(OS_CHROMEOS)
static const char kAppWarningLearnMoreUrl[] =
"chrome-extension://honijodknafkokifofgiaalefdiedpko/main.html"
@@ -301,6 +303,13 @@ const LocalizedErrorMap net_error_options[] = {
IDS_ERRORPAGES_DETAILS_BLOCKED_ENROLLMENT_CHECK_PENDING,
SUGGEST_CHECK_CONNECTION,
},
+ {net::ERR_SSL_NEEDS_MORE_FALLBACK,
+ IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_SSL_NEEDS_MORE_FALLBACK,
+ IDS_ERRORPAGES_SUMMARY_SSL_NEEDS_MORE_FALLBACK,
+ IDS_ERRORPAGES_DETAILS_SSL_NEEDS_MORE_FALLBACK,
+ SUGGEST_LEARNMORE,
+ },
};
// Special error page to be used in the case of navigating back to a page
@@ -804,6 +813,9 @@ void LocalizedError::GetStrings(int error_code,
case net::ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY:
learn_more_url = GURL(kWeakDHKeyLearnMoreUrl);
break;
+ case net::ERR_SSL_NEEDS_MORE_FALLBACK:
+ learn_more_url = GURL(kSSLv3FallbackUrl);
+ break;
default:
break;
}

Powered by Google App Engine
This is Rietveld 408576698