Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.
Issue 619463002: net: disable SSLv3 fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ... Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 6795059ef633f73ed735031aba6110f150ec1518..7cc2c56e6beff6853aef729db42b050bbeeee498 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -9203,6 +9203,16 @@ Keep your key file in a safe place. You will need it to create new versions of y
SSL protocol error.
</message>
+ <message name="IDS_ERRORPAGES_HEADING_SSL_NEEDS_MORE_FALLBACK" desc="Heading in the error page for SSL fallback errors.">
+ SSL server probably obsolete.
+ </message>
+ <message name="IDS_ERRORPAGES_SUMMARY_SSL_NEEDS_MORE_FALLBACK" desc="Summary in the error page for SSL fallback errors.">
+ Chrome was unable to make an acceptably secure connection to the server. Chrome has workarounds to deal with old and buggy HTTPS servers and the most extreme of these workarounds does appear to have been able to make a connection to this server, which is why Chrome may have conected to it previously. However, new research has found that this workaround causes significant security problems for all Chrome users and thus it has been disabled. It is possible, for the moment, to reenable this workaround by adding the command line flag --ssl-version-fallback-min=ssl3. However, you should fix the server promptly because this may not be supported forever.
felt 2014/10/01 02:22:18 These strings have the product name in them, so th
agl 2014/10/01 21:10:53 There seem to be lots of uses of "Chrome" and plac
felt 2014/10/01 21:28:10 The placeholder method is the deprecated way. Inst
felt 2014/10/01 21:29:08 For example take a look at how IDS_SSL_CLOCK_ERROR
agl 2014/10/01 23:02:39 None of the other error messages phrase it as "Chr
+ </message>
felt 2014/10/01 02:22:18 That's a pretty long paragraph, and I'm not sure t
mmenke 2014/10/01 02:23:50 +1 to *not* suggesting the command line flag. Tha
agl 2014/10/01 21:10:53 Have removed mention of the command line flag in t
felt 2014/10/01 21:40:32 If it's meant for developers, I'd recommend making
agl 2014/10/01 23:02:39 It's aimed at the later, although there's a signif
felt 2014/10/01 23:13:54 My feedback is that the following things are confu
+ <message name="IDS_ERRORPAGES_DETAILS_SSL_NEEDS_MORE_FALLBACK" desc="The error message displayed for SSL protocol errors.">
+ An SSLv3 fallback was able to handshake with the server but we no longer accept SSLv3 fallbacks due to new attacks against the protocol. The server needs to be updated to support a minimum of TLS 1.0 and preferably TLS 1.2.
+ </message>
+
<message name="IDS_ERRORPAGES_HEADING_PINNING_FAILURE" desc="Title of the error page for a certificate which doesn't match the built-in pins for that name">
Incorrect certificate for host.
</message>
« no previous file with comments | « no previous file | chrome/browser/net/ssl_config_service_manager_pref.cc » ('j') | chrome/common/localized_error.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698