Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: content/common/gpu/gpu_channel.cc

Issue 619453002: gpu: Remove Echo and SwapCompletion GL interfacess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tits
Patch Set: remove comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel.h ('k') | content/common/gpu/gpu_command_buffer_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel.cc
diff --git a/content/common/gpu/gpu_channel.cc b/content/common/gpu/gpu_channel.cc
index 8e9c226886f5eeef45cfd5f9dc7719728ce839e7..3b4647e26e71b40ce399e7b0e7c839d02d29bea6 100644
--- a/content/common/gpu/gpu_channel.cc
+++ b/content/common/gpu/gpu_channel.cc
@@ -662,112 +662,58 @@ bool GpuChannel::OnControlMessageReceived(const IPC::Message& msg) {
return handled;
}
-size_t GpuChannel::MatchSwapBufferMessagesPattern(
- IPC::Message* current_message) {
- DCHECK(current_message);
- if (deferred_messages_.empty() || !current_message)
- return 0;
- // Only care about AsyncFlush message.
- if (current_message->type() != GpuCommandBufferMsg_AsyncFlush::ID)
- return 0;
-
- size_t index = 0;
- int32 routing_id = current_message->routing_id();
-
- // Fetch the first message and move index to point to the second message.
- IPC::Message* first_message = deferred_messages_[index++];
-
- // If the current message is AsyncFlush, the expected message sequence for
- // SwapBuffer should be AsyncFlush->Echo. We only try to match Echo message.
- if (current_message->type() == GpuCommandBufferMsg_AsyncFlush::ID &&
- first_message->type() == GpuCommandBufferMsg_Echo::ID &&
- first_message->routing_id() == routing_id) {
- return 1;
- }
-
- // No matched message is found.
- return 0;
-}
-
void GpuChannel::HandleMessage() {
handle_messages_scheduled_ = false;
if (deferred_messages_.empty())
return;
- size_t matched_messages_num = 0;
- bool should_handle_swapbuffer_msgs_immediate = false;
IPC::Message* m = NULL;
GpuCommandBufferStub* stub = NULL;
- do {
- m = deferred_messages_.front();
- stub = stubs_.Lookup(m->routing_id());
- if (stub) {
- if (!stub->IsScheduled())
- return;
- if (stub->IsPreempted()) {
- OnScheduled();
- return;
- }
+ m = deferred_messages_.front();
+ stub = stubs_.Lookup(m->routing_id());
+ if (stub) {
+ if (!stub->IsScheduled())
+ return;
+ if (stub->IsPreempted()) {
+ OnScheduled();
+ return;
}
+ }
- scoped_ptr<IPC::Message> message(m);
- deferred_messages_.pop_front();
- bool message_processed = true;
-
- currently_processing_message_ = message.get();
- bool result;
- if (message->routing_id() == MSG_ROUTING_CONTROL)
- result = OnControlMessageReceived(*message);
- else
- result = router_.RouteMessage(*message);
- currently_processing_message_ = NULL;
-
- if (!result) {
- // Respond to sync messages even if router failed to route.
- if (message->is_sync()) {
- IPC::Message* reply = IPC::SyncMessage::GenerateReply(&*message);
- reply->set_reply_error();
- Send(reply);
- }
- } else {
- // If the command buffer becomes unscheduled as a result of handling the
- // message but still has more commands to process, synthesize an IPC
- // message to flush that command buffer.
- if (stub) {
- if (stub->HasUnprocessedCommands()) {
- deferred_messages_.push_front(new GpuCommandBufferMsg_Rescheduled(
- stub->route_id()));
- message_processed = false;
- }
- }
+ scoped_ptr<IPC::Message> message(m);
+ deferred_messages_.pop_front();
+ bool message_processed = true;
+
+ currently_processing_message_ = message.get();
+ bool result;
+ if (message->routing_id() == MSG_ROUTING_CONTROL)
+ result = OnControlMessageReceived(*message);
+ else
+ result = router_.RouteMessage(*message);
+ currently_processing_message_ = NULL;
+
+ if (!result) {
+ // Respond to sync messages even if router failed to route.
+ if (message->is_sync()) {
+ IPC::Message* reply = IPC::SyncMessage::GenerateReply(&*message);
+ reply->set_reply_error();
+ Send(reply);
}
- if (message_processed)
- MessageProcessed();
-
- if (deferred_messages_.empty())
- break;
-
- // We process the pending messages immediately if these messages matches
- // the pattern of SwapBuffers, for example, GLRenderer always issues
- // SwapBuffers calls with a specific IPC message patterns, for example,
- // it should be AsyncFlush->Echo sequence.
- //
- // Instead of posting a task to message loop, it could avoid the possibility
- // of being blocked by other channels, and make SwapBuffers executed as soon
- // as possible.
- if (!should_handle_swapbuffer_msgs_immediate) {
- // Start from the current processing message to match SwapBuffer pattern.
- matched_messages_num = MatchSwapBufferMessagesPattern(message.get());
- should_handle_swapbuffer_msgs_immediate =
- matched_messages_num > 0 && stub;
- } else {
- DCHECK_GT(matched_messages_num, 0u);
- --matched_messages_num;
- if (!stub || matched_messages_num == 0)
- should_handle_swapbuffer_msgs_immediate = false;
+ } else {
+ // If the command buffer becomes unscheduled as a result of handling the
+ // message but still has more commands to process, synthesize an IPC
+ // message to flush that command buffer.
+ if (stub) {
+ if (stub->HasUnprocessedCommands()) {
+ deferred_messages_.push_front(new GpuCommandBufferMsg_Rescheduled(
+ stub->route_id()));
+ message_processed = false;
+ }
}
- } while (should_handle_swapbuffer_msgs_immediate);
+ }
+ if (message_processed)
+ MessageProcessed();
if (!deferred_messages_.empty()) {
OnScheduled();
« no previous file with comments | « content/common/gpu/gpu_channel.h ('k') | content/common/gpu/gpu_command_buffer_stub.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698