Remove the domain check gating settings protection.

Remove the domain check gating settings protection.

TBR=jwd@chromium.org
BUG=325447
Committed: https://crrev.com/7aa4a8aa24612b36878415c27c7bb22461637f75
Cr-Commit-Position: refs/heads/master@{#297947}

[gab, 2014-10-02 21:28:31]

gab@chromium.org changed reviewers:
+ jwd@chromium.org, robertshield@chromium.org

[gab, 2014-10-02 21:28:32]

Robert PTAL.

TBR jwd for trivial histograms.xml change.

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
File chrome/browser/prefs/chrome_pref_service_factory.h (left):

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
chrome/browser/prefs/chrome_pref_service_factory.h:92: void
SchedulePrefHashStoresUpdateCheck(
Was left behind in the header in a previous cleanup looks like..

[robertshield, 2014-10-02 21:40:44]

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
chrome/browser/prefs/chrome_pref_service_factory.cc:486:
base::TimeDelta::FromSeconds(kVerifyPrefsFileDelaySeconds));
do you not still desire to be able to disable the delay for testing?

[gab, 2014-10-02 21:46:01]

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
chrome/browser/prefs/chrome_pref_service_factory.cc:486:
base::TimeDelta::FromSeconds(kVerifyPrefsFileDelaySeconds));
On 2014/10/02 21:40:43, robertshield wrote:
> do you not still desire to be able to disable the delay for testing?

It wasn't used (i.e. nothing tests this -- removing the delay would force this
code to at least run incidentally as part of PrefHashBrowserTests which disabled
delays/domain_check for the sake of the domain_check only, but this wasn't
intentional... maybe a test for this could be introduced if you think it's
worthwhile).

FWIW, do we even still care about this verification?

[robertshield, 2014-10-02 21:53:04]

lgtm

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/619423002/diff/1/chrome/browser/prefs/chrome_...
chrome/browser/prefs/chrome_pref_service_factory.cc:486:
base::TimeDelta::FromSeconds(kVerifyPrefsFileDelaySeconds));
On 2014/10/02 21:46:00, gab (OOO Oct. 4 - Oct. 28) wrote:
> On 2014/10/02 21:40:43, robertshield wrote:
> > do you not still desire to be able to disable the delay for testing?
> 
> It wasn't used (i.e. nothing tests this -- removing the delay would force this
> code to at least run incidentally as part of PrefHashBrowserTests which
disabled
> delays/domain_check for the sake of the domain_check only, but this wasn't
> intentional... maybe a test for this could be introduced if you think it's
> worthwhile).
> 
> FWIW, do we even still care about this verification?

Not overly, no. I think this CL is fine as is.

[gab, 2014-10-02 21:56:26]

Thanks, TBR jwd for obsoletage in histograms.xml

[gab, 2014-10-02 21:56:30]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-10-02 21:57:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619423002/1

[commit-bot: I haz the power, 2014-10-02 23:26:14]

Committed patchset #1 (id:1) as 9cbdb7f9eee16fd4995001d5e4e6535bedc40a38

[commit-bot: I haz the power, 2014-10-02 23:26:56]

Patchset 1 (id:??) landed as
https://crrev.com/7aa4a8aa24612b36878415c27c7bb22461637f75
Cr-Commit-Position: refs/heads/master@{#297947}