Issue 619393002: Add chrome://bookmarks to Buildbot compilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 619393002: Add chrome://bookmarks to Buildbot compilation (Closed)

Created:
6 years, 2 months ago by Vitaly Pavlenko

Modified:
6 years, 2 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master

Project:
chromium

Visibility:
Public.

Add chrome://bookmarks to Buildbot compilation R=dbeam@chromium.org BUG=393873 NOTRY=true TEST=GYP_GENERATORS=ninja gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/4d81da28020a29b03794971cfe943b71602bb373 Cr-Commit-Position: refs/heads/master@{#297909}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	third_party/closure_compiler/compiled_resources.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	third_party/closure_compiler/runner/runner.jar	View		Binary file		0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619393002/1

6 years, 2 months ago (2014-10-02 21:33:22 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 198f33039a9893da8f0b324af8cdd047586b0af3

6 years, 2 months ago (2014-10-02 21:34:46 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-02 21:35:24 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4d81da28020a29b03794971cfe943b71602bb373
Cr-Commit-Position: refs/heads/master@{#297909}