Chromium Code Reviews

Unified Diff: Source/modules/screen_orientation/ScreenOrientationDispatcher.h

Issue 619383002: Move PlatformEventDispatcher implementations to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Only call stopUpdating() from controller dtors when without Oilpan Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/modules/screen_orientation/ScreenOrientationDispatcher.h
diff --git a/Source/modules/screen_orientation/ScreenOrientationDispatcher.h b/Source/modules/screen_orientation/ScreenOrientationDispatcher.h
index 5fef6c68c55f849bacdcc509a9a4c923e0f67f8c..7218b2376a5edcb072b9ad881e1b27913e132f28 100644
--- a/Source/modules/screen_orientation/ScreenOrientationDispatcher.h
+++ b/Source/modules/screen_orientation/ScreenOrientationDispatcher.h
@@ -6,12 +6,10 @@
#define ScreenOrientationDispatcher_h
#include "core/frame/PlatformEventDispatcher.h"
+#include "platform/heap/Handle.h"
namespace blink {
-class FrameView;
-class ScreenOrientation;
-
// ScreenOrientationDispatcher is a singleton that handles whether the current
// Blink instance should be listening to the screen orientation platform events.
// It is not a common implementation of PlatformEventDispatcher in the sense
@@ -20,14 +18,14 @@ class ScreenOrientation;
// but some platforms require to poll to have an accurate reporting. When
// ScreenOrientationDispatcher is listening, that means that the platform should
// be polling if required.
-class ScreenOrientationDispatcher FINAL :
- public PlatformEventDispatcher {
+class ScreenOrientationDispatcher final : public GarbageCollectedFinalized<ScreenOrientationDispatcher>, public PlatformEventDispatcher {
public:
static ScreenOrientationDispatcher& instance();
+ virtual void trace(Visitor*) override;
+
private:
ScreenOrientationDispatcher();
- virtual ~ScreenOrientationDispatcher();
// Inherited from PlatformEventDispatcher.
virtual void startListening() OVERRIDE;

Powered by Google App Engine