Source/modules/battery/BatteryManager.h - Issue 619383002: Move PlatformEventDispatcher implementations to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/battery/BatteryManager.h

Issue 619383002: Move PlatformEventDispatcher implementations to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Only call stopUpdating() from controller dtors when without Oilpan Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/PlatformEventDispatcher.h ('K') | « Source/modules/battery/BatteryDispatcher.cpp ('k') | Source/modules/battery/BatteryManager.cpp » ('j') | Source/modules/device_light/DeviceLightDispatcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/battery/BatteryManager.h

diff --git a/Source/modules/battery/BatteryManager.h b/Source/modules/battery/BatteryManager.h

index 42f4f29b6724fa86e3e97e21913c9cf015e2c1f2..a1d784f4fa9a7f37dffd1ff313a4d8df4d2d1fec 100644

--- a/Source/modules/battery/BatteryManager.h

+++ b/Source/modules/battery/BatteryManager.h

@@ -21,8 +21,8 @@ class BatteryManager FINAL : public RefCountedGarbageCollectedWillBeGarbageColle

DEFINE_WRAPPERTYPEINFO();

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(BatteryManager);

public:

- virtual ~BatteryManager();

static BatteryManager* create(ExecutionContext*);

+ virtual ~BatteryManager();

// Returns a promise object that will be resolved with this BatteryManager.

ScriptPromise startRequest(ScriptState*);