Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 619303002: Fix a missing dependency missing extensions.gyp. (Closed)

Created:
6 years, 2 months ago by Xi Han
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This is due to the include of "extensions/grid/extensions_resources.h" in extension_api.cc. The missing this dependency was already introduced in gn build (https://codereview.chromium.org/596003002/) but not in the extensions.gyp. The missing dependency will fail to build app_shell. BUG=352293 Committed: https://crrev.com/46c567aecd2b80239fee6fc4006474db9c281229 Cr-Commit-Position: refs/heads/master@{#297860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M extensions/extensions.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Xi Han
6 years, 2 months ago (2014-10-02 14:07:34 UTC) #2
Fady Samuel
lgtm
6 years, 2 months ago (2014-10-02 14:20:38 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-02 17:08:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619303002/1
6 years, 2 months ago (2014-10-02 17:48:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2daed45338ecb50336332a28f60b81022f9dde9c
6 years, 2 months ago (2014-10-02 17:55:31 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 17:56:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46c567aecd2b80239fee6fc4006474db9c281229
Cr-Commit-Position: refs/heads/master@{#297860}

Powered by Google App Engine
This is Rietveld 408576698