Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 61923006: Test that AllocationSite::dependent_code doesn't leak code objects. (Closed)

Created:
7 years, 1 month ago by mvstanton
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Test that AllocationSite::dependent_code doesn't leak code objects. Verify that code objects are treated weakly by the AllocationSite dependent_code field. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17887

Patch Set 1 #

Patch Set 2 : Nit fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M test/cctest/test-heap.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Ulan, here is the additional test we discussed. Thanks, --Michael
7 years, 1 month ago (2013-11-19 16:50:31 UTC) #1
ulan
LGTM
7 years, 1 month ago (2013-11-19 16:52:11 UTC) #2
mvstanton
7 years, 1 month ago (2013-11-19 16:57:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17887.

Powered by Google App Engine
This is Rietveld 408576698