Clean up uses of use_glib that are not related to glib dependencies

Clean up uses of use_glib that are not related to glib dependencies

We're frequently using the use_glib gyp variable as a shorthand for:

  OS!="win" and OS!="mac" and OS!="ios" and OS!="android"

This should be equivalent to:

  desktop_linux == 1 or chromeos == 1

Embedded builds want to remove as many dependencies as possible. This
cleans up uses of the use_glib variable so we can turn it off on linux
without breaking the build.

BUG=316226
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233804

[Nico, 2013-11-07 16:15:32]

What's this for?

I don't like repeating this OS list over and over. Maybe we should have
os_non_apple_posix in addition to os_posix and then use os_non_apple_posix &&
OS!=android in all these places instead?

[Ben Goodger (Google), 2013-11-07 16:18:39]

+1... I trust developers to remember a single variable more than I trust
them to remember to include openbsd in every conditional...

-Ben


On Thu, Nov 7, 2013 at 8:15 AM, <thakis@chromium.org> wrote:

> What's this for?
>
> I don't like repeating this OS list over and over. Maybe we should have
> os_non_apple_posix in addition to os_posix and then use os_non_apple_posix
> &&
> OS!=android in all these places instead?
>
> https://codereview.chromium.org/61923004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spang, 2013-11-07 16:31:40]

On 2013/11/07 16:15:32, Nico (ooo until Nov 12) wrote:
> What's this for?
> 
> I don't like repeating this OS list over and over. Maybe we should have
> os_non_apple_posix in addition to os_posix and then use os_non_apple_posix &&
> OS!=android in all these places instead?

This is preparation to enable specifying use_glib=0 on linux to remove glib
dependencies.

[Nico, 2013-11-07 16:37:18]

On Thu, Nov 7, 2013 at 8:31 AM, <spang@chromium.org> wrote:

> On 2013/11/07 16:15:32, Nico (ooo until Nov 12) wrote:
>
>> What's this for?
>>
>
>  I don't like repeating this OS list over and over. Maybe we should have
>> os_non_apple_posix in addition to os_posix and then use
>> os_non_apple_posix &&
>> OS!=android in all these places instead?
>>
>
> This is preparation to enable specifying use_glib=0 on linux to remove glib
> dependencies.
>

Can you file a tracking bug for this and reference this in all your CLs for
this effort? Maybe the bug could say why this is worth doing too.


>
> https://codereview.chromium.org/61923004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spang, 2013-11-07 16:48:12]

On 2013/11/07 16:18:39, Ben Goodger (Google) wrote:
> +1... I trust developers to remember a single variable more than I trust
> them to remember to include openbsd in every conditional...
> 
> -Ben
> 

Isn't it up to the BSD/Solaris porters to add it? I didn't think these platforms
were really supported. I agree in principle with abbreviating but I struggle to
find a shorthand that feels right.

The negated form might be safer since it only lists platforms with trybots:

  OS!="win" and OS!="mac" and OS!="ios" and OS!="android"

Or do we really want a posix_no_apple_no_android flag? It doesn't seem like an
improvement. POSIX is the same as "not windows" and not apple is the same as
"not mac and not ios".

Michael


> 
> On Thu, Nov 7, 2013 at 8:15 AM, <mailto:thakis@chromium.org> wrote:
> 
> > What's this for?
> >
> > I don't like repeating this OS list over and over. Maybe we should have
> > os_non_apple_posix in addition to os_posix and then use os_non_apple_posix
> > &&
> > OS!=android in all these places instead?
> >
> > https://codereview.chromium.org/61923004/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[spang, 2013-11-07 17:20:43]

On 2013/11/07 16:37:18, Nico (ooo until Nov 12) wrote:
> On Thu, Nov 7, 2013 at 8:31 AM, <mailto:spang@chromium.org> wrote:
> 
> > On 2013/11/07 16:15:32, Nico (ooo until Nov 12) wrote:
> >
> >> What's this for?
> >>
> >
> >  I don't like repeating this OS list over and over. Maybe we should have
> >> os_non_apple_posix in addition to os_posix and then use
> >> os_non_apple_posix &&
> >> OS!=android in all these places instead?
> >>
> >
> > This is preparation to enable specifying use_glib=0 on linux to remove glib
> > dependencies.
> >
> 
> Can you file a tracking bug for this and reference this in all your CLs for
> this effort? Maybe the bug could say why this is worth doing too.

Filed https://code.google.com/p/chromium/issues/detail?id=316226 . There's not
really any more that can be said in the bug than I have in my CL description,
though.

> 
> 
> >
> > https://codereview.chromium.org/61923004/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[spang, 2013-11-07 18:39:43]

PTAL

sadrul pointed out that freebsd, openbsd, and solaris all set desktop_linux==1.

So 'desktop_linux == 1 or chromeos == 1' is the same as 'OS=="linux" or
OS=="freebsd" or OS=="openbsd" or OS=="solaris"'.

[Ben Goodger (Google), 2013-11-07 18:48:24]

lgtm

https://codereview.chromium.org/61923004/diff/120001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/61923004/diff/120001/base/base.gyp#newcode38
base/base.gyp:38: ['desktop_linux == 1 or chromeos == 1', {
this is way better.

[commit-bot: I haz the power, 2013-11-07 19:10:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/61923004/120001

[commit-bot: I haz the power, 2013-11-08 06:25:00]

Change committed as 233804

[M-A Ruel, 2014-01-26 20:39:55]

https://codereview.chromium.org/61923004/diff/120001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/61923004/diff/120001/base/base.gyp#newcode755
base/base.gyp:755: ['desktop_linux == 1 or chromeos == 1', {
It's duplicate, please merge lines 694-698 into here.