Issue 61923003: Timeline: show impl-side frames on the Timeline overview

Issue 61923003: Timeline: show impl-side frames on the Timeline overview (Closed)

Created:
7 years, 1 month ago by caseq

Modified:
7 years ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: show impl-side frames on the Timeline overview Expose impl-side frames as additional row of vertical bars on top of Timeline frame mode overview. BUG=305863 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163000

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebased, addressed review comments, added a test #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+587 lines, -45 lines)			Patch
M	LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	LayoutTests/inspector/timeline/timeline-frame-controller.html	View	1	1 chunk	+134 lines, -0 lines	0 comments	Download
A	LayoutTests/inspector/timeline/timeline-frame-controller-expected.txt	View	1	1 chunk	+313 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/TimelineFrameController.js	View	1	6 chunks	+39 lines, -25 lines	0 comments	Download
M	Source/devtools/front_end/TimelineModel.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/TimelineOverviewPane.js	View	1	10 chunks	+91 lines, -15 lines	0 comments	Download
M	Source/devtools/front_end/TimelinePresentationModel.js	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/inspectorCommon.css	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timelinePanel.css	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://chromiumcodereview.appspot.com/61923003/diff/1/Source/devtools/front_end/TimelineFrameController.js File Source/devtools/front_end/TimelineFrameController.js (right): https://chromiumcodereview.appspot.com/61923003/diff/1/Source/devtools/front_end/TimelineFrameController.js#newcode114 Source/devtools/front_end/TimelineFrameController.js:114: return record.thread ? this._lastBackgroundFrame : this._lastMainThreadFrame; inline https://chromiumcodereview.appspot.com/61923003/diff/1/Source/devtools/front_end/TimelineOverviewPane.js ...

7 years, 1 month ago (2013-11-06 17:21:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/61923003/100001

7 years ago (2013-12-02 15:10:13 UTC) #4

Message was sent while issue was closed.

Change committed as 163000

Expand Messages | Collapse Messages