[Installer] Make recent install_worker.cc changes use AppRegistrationData

[Installer] Make recent install_worker.cc changes use AppRegistrationData

Recent change https://codereview.chromium.org/612093007/ in install_worker.cc
uses BrowserDistribution::CHROME_APP_HOST, which we wish to remove. So we
refactoring this to use AppRegistrationData instead.

BUG=297647
Committed: https://crrev.com/c7a808cb0365ab7387206fd2fd44bf9681ca771a
Cr-Commit-Position: refs/heads/master@{#297914}

[huangs, 2014-10-01 20:04:15]

huangs@chromium.org changed reviewers:
+ grt@chromium.org

[huangs, 2014-10-01 20:04:18]

May as well chip away at this small piece quickly.  PTAL.

[grt (UTC plus 2), 2014-10-01 20:14:26]

thanks!

https://codereview.chromium.org/619203002/diff/1/chrome/installer/setup/insta...
File chrome/installer/setup/install_worker.cc (right):

https://codereview.chromium.org/619203002/diff/1/chrome/installer/setup/insta...
chrome/installer/setup/install_worker.cc:190: base::string16
GetRegCommandKey(const AppRegistrationData& reg_data,
this makes all callers' lives a bit more difficult. how about leaving the
signature of GetRegCommandKey as-is and have it delegate to
GetRegistrationDataCommandKey, or something similar?

[huangs, 2014-10-01 22:28:48]

Patchset #2 (id:20001) has been deleted

[huangs, 2014-10-01 22:36:24]

Patchset #2 (id:40001) has been deleted

[huangs, 2014-10-01 22:39:20]

Updated, PTAL.

https://codereview.chromium.org/619203002/diff/1/chrome/installer/setup/insta...
File chrome/installer/setup/install_worker.cc (right):

https://codereview.chromium.org/619203002/diff/1/chrome/installer/setup/insta...
chrome/installer/setup/install_worker.cc:190: base::string16
GetRegCommandKey(const AppRegistrationData& reg_data,
On 2014/10/01 20:14:26, grt wrote:
> this makes all callers' lives a bit more difficult. how about leaving the
> signature of GetRegCommandKey as-is and have it delegate to
> GetRegistrationDataCommandKey, or something similar?

Done.

[huangs, 2014-10-02 19:41:44]

Ping grt@. Thanks!

[grt (UTC plus 2), 2014-10-02 20:24:18]

lgtm

[huangs, 2014-10-02 21:16:33]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-10-02 21:18:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619203002/60001

[commit-bot: I haz the power, 2014-10-02 21:57:48]

Committed patchset #2 (id:60001) as d8d81f52060800736391b7bb4977b1c3d8d690af

[commit-bot: I haz the power, 2014-10-02 21:58:50]

Patchset 2 (id:??) landed as
https://crrev.com/c7a808cb0365ab7387206fd2fd44bf9681ca771a
Cr-Commit-Position: refs/heads/master@{#297914}