Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 619183002: Move check for gesture end events out of RootViewTargeter (Closed)

Created:
6 years, 2 months ago by tdanderson
Modified:
6 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move check for gesture end events out of RootViewTargeter Instead of returning a NULL target for a ET_GESTURE_END in the case where no default gesture handler has been established, prevent processing in RootView::OnEventProcessingStarted() by marking the event as handled. BUG=417771 TEST=ViewTargeterTest.ViewTargeterForGestureEvents changed, WidgetTest.GestureEndEvents changed, WidgetTest.GestureEventsNotProcessed changed, WidgetTest.DisabledGestureEventTarget changed Committed: https://crrev.com/c9f8dbb5d34e0b92f4b9818c5ff1e37fc34768f8 Cr-Commit-Position: refs/heads/master@{#297897}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M ui/views/view_targeter_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ui/views/widget/root_view_targeter.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 4 chunks +18 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tdanderson
Sadrul, can you please take a look?
6 years, 2 months ago (2014-10-01 17:50:46 UTC) #2
sadrul
lgtm https://codereview.chromium.org/619183002/diff/1/ui/events/event_processor.cc File ui/events/event_processor.cc (right): https://codereview.chromium.org/619183002/diff/1/ui/events/event_processor.cc#newcode29 ui/events/event_processor.cc:29: // dispatch of the event is not permitted. ...
6 years, 2 months ago (2014-10-02 19:23:04 UTC) #3
tdanderson
Sadrul, comments addressed, but I do have a response below: https://codereview.chromium.org/619183002/diff/1/ui/events/event_processor.cc File ui/events/event_processor.cc (right): https://codereview.chromium.org/619183002/diff/1/ui/events/event_processor.cc#newcode29 ...
6 years, 2 months ago (2014-10-02 19:35:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619183002/20001
6 years, 2 months ago (2014-10-02 19:36:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c34d721da0a02f7ce05496963c4d09900eda643b
6 years, 2 months ago (2014-10-02 20:50:29 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:50:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9f8dbb5d34e0b92f4b9818c5ff1e37fc34768f8
Cr-Commit-Position: refs/heads/master@{#297897}

Powered by Google App Engine
This is Rietveld 408576698